Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix db.useEmulator #4828

Merged
merged 2 commits into from
Apr 27, 2021
Merged

Fix db.useEmulator #4828

merged 2 commits into from
Apr 27, 2021

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Apr 23, 2021

We need to invoke repoManagerApplyEmulatorSettings with db._repoInternal as db._repo starts the WebSocket connection if it hasn't yet been started and applies the production host.

Also random unrelated cleanup.

Fixes #4811

@schmidt-sebastian schmidt-sebastian requested a review from jsdt as a code owner April 23, 2021 15:57
@changeset-bot
Copy link

changeset-bot bot commented Apr 23, 2021

🦋 Changeset detected

Latest commit: a829398

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@firebase/database Patch
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yuchenshi
Copy link
Member

Confirmed locally that this fixes a race condition

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/database

    Type Base (d442eb2) Head (28070a9) Diff
    browser 291 kB 291 kB -14 B (-0.0%)
    esm2017 261 kB 261 kB -8 B (-0.0%)
    main 294 kB 294 kB -14 B (-0.0%)
    module 291 kB 291 kB -14 B (-0.0%)
  • @firebase/database-compat

    Type Base (d442eb2) Head (28070a9) Diff
    browser 84.3 kB 84.3 kB -16 B (-0.0%)
    main 99.7 kB 99.7 kB -22 B (-0.0%)
    module 84.3 kB 84.3 kB -16 B (-0.0%)
  • @firebase/database-exp

    Type Base (d442eb2) Head (28070a9) Diff
    browser 242 kB 242 kB -8 B (-0.0%)
    main 273 kB 273 kB -14 B (-0.0%)
    module 242 kB 242 kB -8 B (-0.0%)
  • firebase

    Type Base (d442eb2) Head (28070a9) Diff
    firebase-database.js 183 kB 183 kB +2 B (+0.0%)
    firebase.js 869 kB 869 kB +2 B (+0.0%)

Test Logs

@yuchenshi yuchenshi merged commit d422436 into master Apr 27, 2021
@yuchenshi yuchenshi deleted the mrschmidt/emulator branch April 27, 2021 16:33
@google-oss-bot google-oss-bot mentioned this pull request Apr 27, 2021
@firebase firebase locked and limited conversation to collaborators May 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Firebase warning connecting to database emulator
5 participants