Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update comments for installations, performance and remote config #4766

Merged
merged 6 commits into from
Apr 9, 2021
Merged

Update comments for installations, performance and remote config #4766

merged 6 commits into from
Apr 9, 2021

Conversation

Feiyang1
Copy link
Member

@Feiyang1 Feiyang1 commented Apr 9, 2021

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Apr 9, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 6f84af3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2021 •
edited
Loading

Size Analysis Report

Affected Products

Diffs between base commit (5fa9bed) and head commit (2bbd3c3) are too large (114,606 characters) to display.

Please check below links to see details from the original test log.

egilmorez
egilmorez reviewed Apr 9, 2021
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have some global nits for you which hopefully won't be too irritating. Thanks!

packages-exp/functions-exp/src/index.ts Outdated Show resolved Hide resolved
packages-exp/installations-exp/src/api/delete-installations.ts Outdated
@@ -24,6 +24,7 @@ import { FirebaseInstallations } from '../interfaces/public-types';

/**
* Deletes the Firebase Installation and all associated data.
* @param installations - The Installations instance
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is "Installations" a literal Fei?

If so, we should backtick it, here and throughout (wherever it is a literal).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the product name, like Firebase App

packages-exp/installations-exp/src/api/on-id-change.ts Outdated Show resolved Hide resolved
packages-exp/installations-exp/src/api/get-id.ts Outdated Show resolved Hide resolved
packages-exp/performance-exp/src/public_types.ts Outdated Show resolved Hide resolved
packages-exp/remote-config-exp/src/api.ts Outdated Show resolved Hide resolved
packages-exp/remote-config-exp/src/api.ts Outdated Show resolved Hide resolved
packages/firestore/exp/index.ts Outdated Show resolved Hide resolved
packages/storage/exp/index.ts Outdated Show resolved Hide resolved
egilmorez
egilmorez approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Apr 9, 2021 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/analytics

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    esm2017 ? 18.7 kB ? (?)
    main ? 24.2 kB ? (?)
    module ? 23.4 kB ? (?)

  • @firebase/app

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 10.8 kB ? (?)
    esm2017 ? 9.57 kB ? (?)
    lite ? 8.88 kB ? (?)
    lite-esm2017 ? 7.87 kB ? (?)
    main ? 9.93 kB ? (?)
    module ? 10.8 kB ? (?)
    react-native ? 9.64 kB ? (?)

  • @firebase/auth

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 181 kB ? (?)
    main ? 181 kB ? (?)
    module ? 181 kB ? (?)

  • @firebase/component

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 7.24 kB ? (?)
    esm2017 ? 5.55 kB ? (?)
    main ? 7.57 kB ? (?)
    module ? 7.24 kB ? (?)

  • @firebase/database

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 292 kB ? (?)
    esm2017 ? 262 kB ? (?)
    main ? 294 kB ? (?)
    module ? 292 kB ? (?)

  • @firebase/database-compat

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 97.5 kB ? (?)
    esm2017 ? 84.3 kB ? (?)
    main ? 99.7 kB ? (?)
    module ? 97.5 kB ? (?)

  • @firebase/database-exp

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 269 kB ? (?)
    esm2017 ? 242 kB ? (?)
    main ? 273 kB ? (?)
    module ? 269 kB ? (?)

  • @firebase/firestore

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 282 kB ? (?)
    esm2017 ? 225 kB ? (?)
    main ? 528 kB ? (?)
    module ? 282 kB ? (?)
    react-native ? 225 kB ? (?)

  • @firebase/firestore-compat

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 28.4 kB ? (?)
    esm2017 ? 28.4 kB ? (?)
    main ? 37.4 kB ? (?)
    module ? 28.4 kB ? (?)
    react-native ? 28.1 kB ? (?)

  • @firebase/firestore-exp

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 223 kB ? (?)
    main ? 505 kB ? (?)
    module ? 223 kB ? (?)
    react-native ? 223 kB ? (?)

  • @firebase/firestore-lite

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 71.3 kB ? (?)
    main ? 145 kB ? (?)
    module ? 71.3 kB ? (?)
    react-native ? 71.5 kB ? (?)

  • @firebase/firestore/bundle

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 288 kB ? (?)
    esm2017 ? 175 kB ? (?)
    main ? 525 kB ? (?)
    module ? 288 kB ? (?)
    react-native ? 175 kB ? (?)

  • @firebase/firestore/memory

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 215 kB ? (?)
    esm2017 ? 171 kB ? (?)
    main ? 323 kB ? (?)
    module ? 215 kB ? (?)
    react-native ? 171 kB ? (?)

  • @firebase/firestore/memory-bundle

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 223 kB ? (?)
    esm2017 ? 175 kB ? (?)
    main ? 320 kB ? (?)
    module ? 223 kB ? (?)
    react-native ? 175 kB ? (?)

  • @firebase/functions

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 9.90 kB ? (?)
    esm2017 ? 7.71 kB ? (?)
    main ? 10.3 kB ? (?)
    module ? 9.90 kB ? (?)

  • @firebase/installations

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    esm2017 ? 16.6 kB ? (?)
    main ? 22.2 kB ? (?)
    module ? 21.6 kB ? (?)

  • @firebase/logger

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    esm2017 ? 3.25 kB ? (?)
    main ? 5.38 kB ? (?)
    module ? 4.65 kB ? (?)

  • @firebase/messaging

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    esm2017 ? 26.2 kB ? (?)
    main ? 34.9 kB ? (?)
    module ? 34.4 kB ? (?)

  • @firebase/performance

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 27.7 kB ? (?)
    esm2017 ? 25.9 kB ? (?)
    main ? 28.0 kB ? (?)
    module ? 27.7 kB ? (?)

  • @firebase/polyfill

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    main ? 747 B ? (?)
    module ? 705 B ? (?)

  • @firebase/remote-config

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 22.4 kB ? (?)
    esm2017 ? 17.4 kB ? (?)
    main ? 23.0 kB ? (?)
    module ? 22.4 kB ? (?)

  • @firebase/rules-unit-testing

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    main ? 12.6 kB ? (?)

  • @firebase/storage

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 62.0 kB ? (?)
    esm2017 ? 53.6 kB ? (?)
    main ? 62.5 kB ? (?)
    module ? 62.0 kB ? (?)

  • @firebase/storage-compat

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 27.8 kB ? (?)
    esm2017 ? 10.2 kB ? (?)
    main ? 28.1 kB ? (?)
    module ? 27.8 kB ? (?)

  • @firebase/storage-exp

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 50.5 kB ? (?)
    main ? 51.6 kB ? (?)
    module ? 50.5 kB ? (?)

  • @firebase/util

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    browser ? 20.2 kB ? (?)
    esm2017 ? 19.0 kB ? (?)
    main ? 24.6 kB ? (?)
    module ? 20.2 kB ? (?)

  • @firebase/webchannel-wrapper

    Type Base (5fa9bed) Head (2bbd3c3) Diff
    esm2017 ? 39.5 kB ? (?)
    main ? 46.9 kB ? (?)
    module ? 40.8 kB ? (?)

  • firebase

    Click to show 15 binary size changes.
    Type Base (5fa9bed) Head (2bbd3c3) Diff
    firebase-analytics.js ? 35.8 kB ? (?)
    firebase-app.js ? 21.2 kB ? (?)
    firebase-auth.js ? 177 kB ? (?)
    firebase-database.js ? 188 kB ? (?)
    firebase-firestore.js ? 327 kB ? (?)
    firebase-firestore.memory.js ? 262 kB ? (?)
    firebase-functions.js ? 10.3 kB ? (?)
    firebase-installations.js ? 19.3 kB ? (?)
    firebase-messaging.js ? 41.0 kB ? (?)
    firebase-performance-standalone.es2017.js ? 72.9 kB ? (?)
    firebase-performance-standalone.js ? 49.2 kB ? (?)
    firebase-performance.js ? 38.3 kB ? (?)
    firebase-remote-config.js ? 36.9 kB ? (?)
    firebase-storage.js ? 40.8 kB ? (?)
    firebase.js ? 873 kB ? (?)

Test Logs

@Feiyang1 Feiyang1 merged commit 9df03c9 into master Apr 9, 2021
@Feiyang1 Feiyang1 deleted the fei-doc-updates branch April 9, 2021 20:50
@firebase firebase locked and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@egilmorez egilmorez egilmorez approved these changes

@avolkovi avolkovi Awaiting requested review from avolkovi

@hiranya911 hiranya911 Awaiting requested review from hiranya911

@jsdt jsdt Awaiting requested review from jsdt

@sam-gc sam-gc Awaiting requested review from sam-gc

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

@yuchenshi yuchenshi Awaiting requested review from yuchenshi

Assignees

@egilmorez egilmorez

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Feiyang1 @google-oss-bot @egilmorez @hsubox76