Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update functions-compat for new InstanceFactory #4638

Merged
merged 5 commits into from
Mar 16, 2021
Merged

Update functions-compat for new InstanceFactory #4638

merged 5 commits into from
Mar 16, 2021

Conversation

hsubox76
Copy link
Contributor

@hsubox76 hsubox76 commented Mar 15, 2021 •
edited
Loading

I think the update for functions-compat missed in #4595

Removed an unused export.

@changeset-bot
Copy link

changeset-bot bot commented Mar 15, 2021 •
edited
Loading

⚠️ No Changeset found

Latest commit: 955efa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 15, 2021 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (4e7c78b) and head commit (9e8ac43).

@hsubox76 hsubox76 changed the title Update functions-compat for new InstanceFactory Update functions (current, compat, and exp) for new InstanceFactory Mar 15, 2021
@hsubox76 hsubox76 force-pushed the ch-functions-compat-fix branch from fa26bb1 to 3a54a89 Compare March 16, 2021 00:36
@hsubox76 hsubox76 changed the title Update functions (current, compat, and exp) for new InstanceFactory Update functions-compat for new InstanceFactory Mar 16, 2021
@Feiyang1 Feiyang1 mentioned this pull request Mar 16, 2021
Merged
@hsubox76 hsubox76 merged commit a6d29aa into master Mar 16, 2021
@hsubox76 hsubox76 deleted the ch-functions-compat-fix branch March 16, 2021 17:49
@firebase firebase locked and limited conversation to collaborators Apr 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@hiranya911 hiranya911 Awaiting requested review from hiranya911

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsubox76 @google-oss-bot @Feiyang1