Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type definitions for get() #4096

Merged
merged 4 commits into from
Nov 20, 2020
Merged

Add type definitions for get() #4096

merged 4 commits into from
Nov 20, 2020

Conversation

jmwski
Copy link
Contributor

@jmwski jmwski commented Nov 19, 2020

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 19, 2020 •
edited
Loading

🦋 Changeset detected

Latest commit: 77500e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:

    • @firebase/database-types

    Make sure this was intentional.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Nov 20, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (3c3c5fa) and head commit (ebb6764).

Test Logs

@Feiyang1 Feiyang1 merged commit 4f63132 into master Nov 20, 2020
@google-oss-bot google-oss-bot mentioned this pull request Nov 20, 2020
Merged
@jmwski jmwski deleted the jw/get-ts-d branch November 20, 2020 00:27
@firebase firebase locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Feiyang1 Feiyang1 Feiyang1 approved these changes

@jsdt jsdt Awaiting requested review from jsdt

@schmidt-sebastian schmidt-sebastian Awaiting requested review from schmidt-sebastian

Assignees

@Feiyang1 Feiyang1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmwski @google-oss-bot @Feiyang1