Fix experimentalAutoDetectLongPolling and add logging #4078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 17824e9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
force-pushed
the
mrschmidt/requesststats
branch
from
b853f48 to
5d819bd
Compare
schmidt-sebastian
changed the title
schmidt-sebastian
changed the title
rafikhan
approved these changes
Nov 17, 2020
| @@ -348,6 +356,16 @@ export class WebChannelConnection extends RestConnection { | |||
| } | |||
| ); | |||
|
|
|||
| unguardedEventListen<StatEvent>(requestStats, Event.STAT_EVENT, event => { | |||
| if (!event) return; | |||
There was a problem hiding this comment.
Is this line necessary? If so, under what conditions would it happen. Might be worth adding a comment.
There was a problem hiding this comment.
It seems like unguardedEventListen can be modified safely to assume that there is always an event. Fixed.
schmidt-sebastian
requested review from
Feiyang1,
hiranya911 and
hsubox76
as code owners
…e-js-sdk into mrschmidt/requesststats
Feiyang1
approved these changes
Nov 19, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in experimentalAutoDetectLongPolling, as the WebChannel flag was not added to the closure externs and as such mangled. It also adds logging for each mode.
Verified with a test app in Chrome (albeit only for the "no buffering proxy" scenario).