Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove timestampsInSnapshots from FirestoreSettings #3897

Merged
merged 2 commits into from
Oct 15, 2020
Merged

Remove timestampsInSnapshots from FirestoreSettings #3897

merged 2 commits into from
Oct 15, 2020

Conversation

thebrianchen
Copy link

@thebrianchen thebrianchen commented Oct 5, 2020 •
edited
Loading

Fixes #3879.

Merging with next breaking change window.

Will add changeset once the .changesset/config.json is updated.

@thebrianchen thebrianchen self-assigned this Oct 5, 2020
@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2020 •
edited
Loading

🦋 Changeset detected

Latest commit: ccd64c2

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 5, 2020 •
edited
Loading

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (795f31a) Head (8fb7647) Diff
    browser 249 kB 249 kB -668 B (-0.3%)
    esm2017 197 kB 196 kB -646 B (-0.3%)
    main 484 kB 483 kB -1.04 kB (-0.2%)
    module 247 kB 246 kB -668 B (-0.3%)
    react-native 197 kB 196 kB -646 B (-0.3%)

  • @firebase/firestore/exp

    Type Base (795f31a) Head (8fb7647) Diff
    browser 189 kB 189 kB -85 B (-0.0%)
    main 477 kB 477 kB -178 B (-0.0%)
    module 189 kB 189 kB -85 B (-0.0%)
    react-native 189 kB 189 kB -85 B (-0.0%)

  • @firebase/firestore/lite

    Type Base (795f31a) Head (8fb7647) Diff
    browser 63.4 kB 63.3 kB -79 B (-0.1%)
    main 140 kB 140 kB -168 B (-0.1%)
    module 63.4 kB 63.3 kB -79 B (-0.1%)
    react-native 63.6 kB 63.6 kB -79 B (-0.1%)

  • @firebase/firestore/memory

    Type Base (795f31a) Head (8fb7647) Diff
    browser 187 kB 186 kB -668 B (-0.4%)
    esm2017 147 kB 147 kB -646 B (-0.4%)
    main 357 kB 356 kB -1.04 kB (-0.3%)
    module 185 kB 184 kB -668 B (-0.4%)
    react-native 147 kB 147 kB -646 B (-0.4%)

  • firebase

    Type Base (795f31a) Head (8fb7647) Diff
    firebase-firestore.js 286 kB 285 kB -670 B (-0.2%)
    firebase-firestore.memory.js 226 kB 225 kB -670 B (-0.3%)
    firebase.js 829 kB 828 kB -670 B (-0.1%)

Test Logs

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 5, 2020 •
edited
Loading

Size Analysis Report

Affected Products

No changes between base commit (795f31a) and head commit (72cb763).

Test Logs

schmidt-sebastian
schmidt-sebastian approved these changes Oct 6, 2020
View reviewed changes
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please do not merge until Thu 15th

@thebrianchen thebrianchen requested a review from Feiyang1 October 14, 2020 18:00
@thebrianchen thebrianchen merged commit ffef32e into master Oct 15, 2020
@google-oss-bot google-oss-bot mentioned this pull request Oct 22, 2020
Merged
@firebase firebase locked and limited conversation to collaborators Nov 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@schmidt-sebastian schmidt-sebastian schmidt-sebastian approved these changes

@Feiyang1 Feiyang1 Feiyang1 approved these changes

Assignees

@Feiyang1 Feiyang1

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The setting 'timestampsInSnapshots: true' is no longer required and should be removed
4 participants
@thebrianchen @google-oss-bot @Feiyang1 @schmidt-sebastian