-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API Extractor for @firestore/lite + exp #3657
Changes from 7 commits
1dfec9a
6c129bf
71790fe
bedb8d9
5cbf013
c7c4779
032b860
f4dfec7
81729b8
7e3f11f
a576652
2e6b656
37c864b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,8 +66,7 @@ | |
"@changesets/changelog-github": "0.2.6", | ||
"@changesets/cli": "2.9.2", | ||
"@microsoft/api-documenter": "7.8.21", | ||
"@microsoft/api-extractor": "7.9.2", | ||
"@types/mz": "2.7.1", | ||
"@microsoft/api-extractor": "7.8.2-pr1796.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This pulls in microsoft/rushstack#1029, which makes this diff about 500 lines smaller (see the revert 609b2b3) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. eh, the commit shows There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, it 500 lines in terms of changed lines. I can go with the version that doesn't require the custom release if you prefer that (which might make sense especially since we seem to waiting on a lot of other PRs). There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. FWIW, I created a new PR to merge just this: #3660 |
||
"@types/chai": "4.2.12", | ||
"@types/chai-as-promised": "7.1.3", | ||
"@types/child-process-promise": "2.2.1", | ||
|
@@ -136,6 +135,7 @@ | |
"ora": "4.0.5", | ||
"prettier": "2.0.5", | ||
"protractor": "5.4.2", | ||
"rollup-plugin-copy": "3.3.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rollup-plugin-copy-asset doesn't allow me to move the proto files to dist/lite/src/proto |
||
"rxjs": "6.6.2", | ||
"semver": "7.3.2", | ||
"simple-git": "1.132.0", | ||
|
@@ -157,4 +157,4 @@ | |
"pre-commit": "node tools/gitHooks/precommit.js" | ||
} | ||
} | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
{ | ||
"extends": "../../../config/api-extractor.json", | ||
"mainEntryPointFilePath": "../dist/exp/firestore/exp/index.d.ts", | ||
"dtsRollup": { | ||
"enabled": true, | ||
"publicTrimmedFilePath": "../dist/exp/index.d.ts" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is in here twice.