Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Share Integration tests between firestore and firestore-exp #3338

Closed
wants to merge 12 commits into from

Conversation

schmidt-sebastian
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2020

💥 No Changeset

Latest commit: 41ce70c

Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂

If these changes should be published to npm, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 2, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (0c8b011) Head (5071674) Diff
    browser 248 kB 248 kB -359 B (-0.1%)
    esm2017 194 kB 194 kB -54 B (-0.0%)
    main 493 kB 493 kB +61 B (+0.0%)
    module 246 kB 245 kB -344 B (-0.1%)
    react-native 194 kB 194 kB -84 B (-0.0%)
  • @firebase/firestore/exp

    Type Base (0c8b011) Head (5071674) Diff
    main 395 kB 396 kB +798 B (+0.2%)
  • @firebase/firestore/lite

    Type Base (0c8b011) Head (5071674) Diff
    main 141 kB 134 kB -6.44 kB (-4.6%)
  • @firebase/firestore/memory

    Type Base (0c8b011) Head (5071674) Diff
    browser 186 kB 185 kB -369 B (-0.2%)
    esm2017 145 kB 145 kB -48 B (-0.0%)
    main 363 kB 363 kB +40 B (+0.0%)
    module 184 kB 184 kB -312 B (-0.2%)
    react-native 145 kB 145 kB -60 B (-0.0%)
  • firebase

    Type Base (0c8b011) Head (5071674) Diff
    firebase-firestore.js 286 kB 286 kB -425 B (-0.1%)
    firebase-firestore.memory.js 226 kB 225 kB -420 B (-0.2%)
    firebase.js 820 kB 819 kB -425 B (-0.1%)

Test Logs

@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/shim branch July 9, 2020 17:44
@firebase firebase locked and limited conversation to collaborators Aug 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants