Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP Remove Mutation types from Lite SDK #3327

Closed
wants to merge 2 commits into from

Conversation

schmidt-sebastian
Copy link
Contributor

@schmidt-sebastian schmidt-sebastian commented Jun 30, 2020

WIP: Find a way to reduce code duplication in firestore/exp

@changeset-bot
Copy link

changeset-bot bot commented Jun 30, 2020

🦋 Changeset is good to go

Latest commit: 5315226

We got this.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 30, 2020

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (982acf9) Head (e98cb0f) Diff
    browser 248 kB 249 kB +717 B (+0.3%)
    esm2017 194 kB 194 kB +794 B (+0.4%)
    main 493 kB 495 kB +1.78 kB (+0.4%)
    module 246 kB 246 kB +717 B (+0.3%)
  • @firebase/firestore/exp

    Type Base (982acf9) Head (e98cb0f) Diff
    main 283 kB 286 kB +3.58 kB (+1.3%)
  • @firebase/firestore/lite

    Type Base (982acf9) Head (e98cb0f) Diff
    main 141 kB 133 kB -7.79 kB (-5.5%)
  • @firebase/firestore/memory

    Type Base (982acf9) Head (e98cb0f) Diff
    browser 186 kB 186 kB +712 B (+0.4%)
    esm2017 145 kB 146 kB +789 B (+0.5%)
    main 363 kB 364 kB +1.78 kB (+0.5%)
    module 184 kB 185 kB +712 B (+0.4%)
  • firebase

    Type Base (982acf9) Head (e98cb0f) Diff
    firebase-firestore.js 286 kB 287 kB +749 B (+0.3%)
    firebase-firestore.memory.js 226 kB 226 kB +744 B (+0.3%)
    firebase.js 819 kB 820 kB +749 B (+0.1%)

Test Logs

@schmidt-sebastian schmidt-sebastian changed the title Remove Mutation types from Lite SDK WIP Remove Mutation types from Lite SDK Jun 30, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/mutations branch July 9, 2020 17:44
@firebase firebase locked and limited conversation to collaborators Jul 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants