Add Snapshot Listeners to firestore-exp #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: f412e9b We got this. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
schmidt-sebastian
requested review from
alikn,
andirayo,
avolkovi,
egilmorez,
erikeldridge,
sam-gc,
scottcrossen,
yuchenshi,
zijianjoy and
zwu52
as code owners
Binary Size ReportAffected SDKs
Test Logs |
rafikhan
requested changes
Jun 29, 2020
rafikhan
approved these changes
Jun 29, 2020
schmidt-sebastian
added a commit
that referenced
this pull request
Jun 30, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Snapshot Listeners to the firestore-exp SDK. It does not add tests, since I want these functions to be tested using the main integration tests.
The PR also adds the call to
validateHasExplicitOrderByForLimitToLastto all Query evaluations. This is needed to make sure thatlimitToLast()is not invoked on an empty Query order, since the backend does not support a reverse index on the document ID.Source for all this code is https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/src/api/database.ts#L1136 and https://github.com/firebase/firebase-js-sdk/blob/master/packages/firestore/src/api/database.ts#L2100