Enable changesets #3268
Merged
Enable changesets #3268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary Size ReportAffected SDKs
Test Logs |
hsubox76
approved these changes
Jun 25, 2020
| return packagePaths | ||
| .map(path => { | ||
| try { | ||
| return require(`${path}/package.json`); | ||
| return JSON.parse(readFileSync(`${path}/package.json`, 'utf8')); |
There was a problem hiding this comment.
Just out of curiosity is it because ts-node can't require json files?
There was a problem hiding this comment.
require caches the content of the package.json, so you will read stale package.json if you read it first, update it, then read it again. using readFile will always get the latest version from disk.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once merged, we will need to install the changeset Github App.