Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove remaining static references #3264

Merged
merged 1 commit into from
Jun 24, 2020

Conversation

schmidt-sebastian
Copy link
Contributor

This changes:

  • ResourcePath.EMPTY_PATH to ResourcePath.emptyPath()
  • FIeldPath.EMPTYPATH to FIeldPath.emptyPath()
  • FIeldPath._DOCUMENT_ID (inlined, only 1 usage)
  • DocumentKey.EMPTY ((inlined, only 2 usages)

@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • @firebase/firestore

    Type Base (acd89ee) Head (6e15ecb) Diff
    browser 248 kB 248 kB +17 B (+0.0%)
    esm2017 194 kB 194 kB +19 B (+0.0%)
    main 492 kB 492 kB -25 B (-0.0%)
    module 246 kB 246 kB +17 B (+0.0%)
  • @firebase/firestore/lite

    Type Base (acd89ee) Head (6e15ecb) Diff
    main 140 kB 140 kB -96 B (-0.1%)
  • @firebase/firestore/memory

    Type Base (acd89ee) Head (6e15ecb) Diff
    browser 186 kB 186 kB +13 B (+0.0%)
    esm2017 145 kB 145 kB +15 B (+0.0%)
    main 362 kB 362 kB -27 B (-0.0%)
    module 184 kB 184 kB +13 B (+0.0%)
  • firebase

    Type Base (acd89ee) Head (6e15ecb) Diff
    firebase-firestore.js 287 kB 287 kB +16 B (+0.0%)
    firebase-firestore.memory.js 226 kB 226 kB +12 B (+0.0%)
    firebase.js 820 kB 820 kB +16 B (+0.0%)

Test Logs

@schmidt-sebastian schmidt-sebastian merged commit 1791a9b into master Jun 24, 2020
schmidt-sebastian added a commit that referenced this pull request Jun 24, 2020
The Lite tests are not yet run in CI. This PR updates the tests after #3189 and #3264.
This was referenced Jun 24, 2020
@schmidt-sebastian schmidt-sebastian deleted the mrschmidt/removestaticrefs branch July 9, 2020 17:45
@firebase firebase locked and limited conversation to collaborators Jul 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants