-
Notifications
You must be signed in to change notification settings - Fork 897
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Admin AuthTokenProvider when targeting Emulator #3228
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9d69fd9
Use empty auth token provider when talking to Emulator
schmidt-sebastian 88e8f22
Another attempt
schmidt-sebastian 84a9b29
Cleanup + Sam's constants
schmidt-sebastian f891b19
Create smooth-poets-leave.md
schmidt-sebastian 7a19477
Update smooth-poets-leave.md
schmidt-sebastian 617dd05
Update smooth-poets-leave.md
schmidt-sebastian 8a978d8
Also support localhost
schmidt-sebastian 54c19f1
Merge branch 'mrschmidt/tokenprovider' of github.com:firebase/firebas…
schmidt-sebastian f0ea3f0
Simplify
schmidt-sebastian 6ba08b7
Merge branch 'master' into mrschmidt/tokenprovider
schmidt-sebastian 004f58d
Lint
schmidt-sebastian File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"firebase": patch | ||
"@firebase/database": patch | ||
--- | ||
|
||
[fix] Instead of using production auth, the SDK will use test credentials | ||
to connect to the Emulator when the RTDB SDK is used via the Firebase | ||
Admin SDK. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this branch
if (dbEmulatorHost) { }
trigger only if the emulator connection is made via env var? What about if the user does this:You might consider using the
EmulatorAdminTokenProvider
any timeConstants.NODE_ADMIN
is true and the database ishttp://
(nothttps://
). That's what we do in the Firebase CLI, it catches more cases and it also has the nice side benefit of not allowing someone's admin credentials to ever go to an insecure host.