Suppress server errors in deleteToken request (#2428)

firebase · Dec 10, 2019 · ff8f854 · ff8f854
1 parent 5a880c6
commit ff8f854
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 10 deletions.
diff --git a/packages/messaging/src/controllers/base-controller.ts b/packages/messaging/src/controllers/base-controller.ts
@@ -238,7 +238,12 @@ export abstract class BaseController
    */
   private async deleteTokenFromDB(token: string): Promise<void> {
     const tokenDetails = await this.tokenDetailsModel.deleteToken(token);
-    await this.subscriptionManager.deleteToken(this.services, tokenDetails);
+    try {
+      await this.subscriptionManager.deleteToken(this.services, tokenDetails);
+    } catch (e) {
+      // A failed server-side delete does not need to break the app.
+      console.error(e);
+    }
   }
 
   // Visible for testing

diff --git a/packages/messaging/test/controller-delete-token.test.ts b/packages/messaging/test/controller-delete-token.test.ts
@@ -210,7 +210,7 @@ describe('Firebase Messaging > *Controller.deleteToken()', () => {
       );
     });
 
-    it(`should handle error on deleteToken ${serviceClass.name}`, () => {
+    it(`should handle error on deleteToken ${serviceClass.name}`, async () => {
       const fakeSubscription: any = {
         endpoint: EXAMPLE_TOKEN_SAVE.endpoint,
         unsubscribe: async () => {}
@@ -233,15 +233,11 @@ describe('Firebase Messaging > *Controller.deleteToken()', () => {
         throw new Error(errorMsg);
       });
 
+      const consoleStub = stub(console, 'error');
+
       messagingService = new serviceClass(firebaseInternalServices);
-      return messagingService.deleteToken(EXAMPLE_TOKEN_SAVE.fcmToken).then(
-        () => {
-          throw new Error('Expected this to reject');
-        },
-        err => {
-          assert.equal(errorMsg, err.message);
-        }
-      );
+      await messagingService.deleteToken(EXAMPLE_TOKEN_SAVE.fcmToken);
+      assert.equal(consoleStub.callCount, 1);
     });
 
     it(`should delete with valid unsubscribe ${serviceClass.name}`, () => {