Skip to content

Commit

Permalink
Fix MIEQ failure against Emulator on CI (#7637)
Browse files Browse the repository at this point in the history
  • Loading branch information
milaGGL authored Sep 21, 2023
1 parent 3492066 commit e30d7a6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions .github/workflows/test-changed-firestore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,8 @@ jobs:
run: cp config/ci.config.json config/project.json
- name: Run tests
run: cd packages/firestore && yarn run ${{ matrix.test-name }}
env:
EXPERIMENTAL_MODE: true

compat-test-firefox:
name: Test Firestore Compatible on Firefox
Expand Down Expand Up @@ -185,6 +187,7 @@ jobs:
run: cd packages/firestore && xvfb-run yarn run ${{ matrix.test-name }}
env:
BROWSERS: 'Firefox'
EXPERIMENTAL_MODE: true

# A job that fails if any required job in the test matrix fails,
# to be used as a required check for merging.
Expand Down
4 changes: 2 additions & 2 deletions scripts/emulator-testing/emulators/firestore-emulator.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,11 @@ export class FirestoreEmulator extends Emulator {

constructor(port: number, projectId = 'test-emulator') {
super(
'cloud-firestore-emulator-v1.14.4.jar',
'cloud-firestore-emulator-v1.18.1.jar',
// Use locked version of emulator for test to be deterministic.
// The latest version can be found from firestore emulator doc:
// https://firebase.google.com/docs/firestore/security/test-rules-emulator
'https://storage.googleapis.com/firebase-preview-drop/emulator/cloud-firestore-emulator-v1.14.4.jar',
'https://storage.googleapis.com/firebase-preview-drop/emulator/cloud-firestore-emulator-v1.18.1.jar',
port
);
this.projectId = projectId;
Expand Down

0 comments on commit e30d7a6

Please sign in to comment.