Re-adding circular dependency check.

firebase · Nov 19, 2024 · cc3146c · cc3146c
1 parent 92c651f
commit cc3146c
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/packages/firestore/rollup.shared.js b/packages/firestore/rollup.shared.js
@@ -96,11 +96,9 @@ exports.resolveNodeExterns = function (id) {
 
 /** Breaks the build if there is a circular dependency. */
 exports.onwarn = function (warning, defaultWarn) {
-  // TODO(pipeline) re-enable and fix circular dependencies after the pipeline exploration phase
-  // if (warning.code === 'CIRCULAR_DEPENDENCY') {
-  //   console.log(JSON.stringify(warning));
-  //   throw new Error(warning);
-  // }
+  if (warning.code === 'CIRCULAR_DEPENDENCY') {
+    throw new Error(warning);
+  }
   defaultWarn(warning);
 };