Don't send empty GMPID header (#4810)

* Don't send empty GMPID header * Create five-wolves-tickle.md
firebase · Apr 21, 2021 · c658836 · c658836
1 parent 3f37021
commit c658836
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 2 deletions.
diff --git a/.changeset/five-wolves-tickle.md b/.changeset/five-wolves-tickle.md
@@ -0,0 +1,5 @@
+---
+"@firebase/firestore": patch
+---
+
+Don't send empty X-Firebase-GMPID header when AppId is not set in FirebaseOptions
diff --git a/packages/firestore/src/platform/node/grpc_connection.ts b/packages/firestore/src/platform/node/grpc_connection.ts
@@ -56,7 +56,9 @@ function createMetadata(
       }
     }
   }
-  metadata.set('X-Firebase-GMPID', appId);
+  if (appId) {
+    metadata.set('X-Firebase-GMPID', appId);
+  }
   metadata.set('X-Goog-Api-Client', X_GOOG_API_CLIENT_VALUE);
   // This header is used to improve routing and project isolation by the
   // backend.

diff --git a/packages/firestore/src/remote/rest_connection.ts b/packages/firestore/src/remote/rest_connection.ts
@@ -119,14 +119,16 @@ export abstract class RestConnection implements Connection {
     token: Token | null
   ): void {
     headers['X-Goog-Api-Client'] = X_GOOG_API_CLIENT_VALUE;
-    headers['X-Firebase-GMPID'] = this.databaseInfo.appId;
 
     // Content-Type: text/plain will avoid preflight requests which might
     // mess with CORS and redirects by proxies. If we add custom headers
     // we will need to change this code to potentially use the $httpOverwrite
     // parameter supported by ESF to avoid triggering preflight requests.
     headers['Content-Type'] = 'text/plain';
 
+    if (this.databaseInfo.appId) {
+      headers['X-Firebase-GMPID'] = this.databaseInfo.appId;
+    }
     if (token) {
       for (const header in token.authHeaders) {
         if (token.authHeaders.hasOwnProperty(header)) {