Allow undefined callbacks in Storage Observer (#3224)

firebase · Jul 9, 2020 · 9c409ea · 9c409ea
1 parent 308f020
commit 9c409ea
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/.changeset/popular-cups-melt.md b/.changeset/popular-cups-melt.md
@@ -0,0 +1,7 @@
+---
+"firebase": patch
+"@firebase/storage-types": patch
+"@firebase/storage": patch
+---
+
+[fix] Updated the TypeScript types for all APIs using Observers to allow callback omission. 
diff --git a/packages/firebase/index.d.ts b/packages/firebase/index.d.ts
@@ -7579,7 +7579,7 @@ declare namespace firebase.storage {
     on(
       event: firebase.storage.TaskEvent,
       nextOrObserver?:
-        | firebase.Observer<UploadTaskSnapshot>
+        | Partial<firebase.Observer<UploadTaskSnapshot>>
         | null
         | ((a: UploadTaskSnapshot) => any),
       error?: ((a: Error) => any) | null,

diff --git a/packages/storage-types/index.d.ts b/packages/storage-types/index.d.ts
@@ -91,7 +91,7 @@ export interface UploadTask {
   on(
     event: TaskEvent,
     nextOrObserver?:
-      | Observer<UploadTaskSnapshot>
+      | Partial<Observer<UploadTaskSnapshot>>
       | null
       | ((a: UploadTaskSnapshot) => any),
     error?: ((a: Error) => any) | null,