Remove undocumented getLogLevel (#3944)

firebase · Oct 15, 2020 · 8939aec · 8939aec
1 parent ffef32e
commit 8939aec
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 34 deletions.
diff --git a/.changeset/great-rice-smash.md b/.changeset/great-rice-smash.md
@@ -0,0 +1,6 @@
+---
+"firebase": major
+"@firebase/firestore": major
+---
+
+Removed the undocumented `Firestore.logLevel` property.
diff --git a/packages/firestore/src/api/database.ts b/packages/firestore/src/api/database.ts
@@ -111,7 +111,7 @@ import {
   valueDescription,
   validateIsNotUsedTogether
 } from '../util/input_validation';
-import { getLogLevel, logError, LogLevel, setLogLevel } from '../util/log';
+import { logError, setLogLevel as setClientLogLevel } from '../util/log';
 import { AutoId } from '../util/misc';
 import { Deferred } from '../util/promise';
 import { FieldPath as ExternalFieldPath } from './field_path';
@@ -752,43 +752,23 @@ export class Firestore implements PublicFirestore, FirebaseService {
     return new WriteBatch(this);
   }
 
-  static get logLevel(): PublicLogLevel {
-    switch (getLogLevel()) {
-      case LogLevel.DEBUG:
-        return 'debug';
-      case LogLevel.ERROR:
-        return 'error';
-      case LogLevel.SILENT:
-        return 'silent';
-      case LogLevel.WARN:
-        return 'warn';
-      case LogLevel.INFO:
-        return 'info';
-      case LogLevel.VERBOSE:
-        return 'verbose';
-      default:
-        // The default log level is error
-        return 'error';
-    }
-  }
-
-  static setLogLevel(level: PublicLogLevel): void {
-    validateExactNumberOfArgs('Firestore.setLogLevel', arguments, 1);
-    validateStringEnum(
-      'setLogLevel',
-      ['debug', 'error', 'silent', 'warn', 'info', 'verbose'],
-      1,
-      level
-    );
-    setLogLevel(level);
-  }
-
   // Visible for testing.
   _getSettings(): PublicSettings {
     return this._settings;
   }
 }
 
+export function setLogLevel(level: PublicLogLevel): void {
+  validateExactNumberOfArgs('Firestore.setLogLevel', arguments, 1);
+  validateStringEnum(
+    'setLogLevel',
+    ['debug', 'error', 'silent', 'warn', 'info', 'verbose'],
+    1,
+    level
+  );
+  setClientLogLevel(level);
+}
+
 /**
  * A reference to a transaction.
  */

diff --git a/packages/firestore/src/config.ts b/packages/firestore/src/config.ts
@@ -29,7 +29,8 @@ import {
   QueryDocumentSnapshot,
   QuerySnapshot,
   Transaction,
-  WriteBatch
+  WriteBatch,
+  setLogLevel
 } from './api/database';
 import { Blob } from './api/blob';
 import { FieldPath } from './api/field_path';
@@ -52,7 +53,7 @@ const firestoreNamespace = {
   CollectionReference,
   FieldPath,
   FieldValue,
-  setLogLevel: Firestore.setLogLevel,
+  setLogLevel,
   CACHE_SIZE_UNLIMITED
 };