Remove toJSON() from index files

firebase · Jan 19, 2021 · 7c31f91 · schmidt-sebastian · Jan 19, 2021 · schmidt-sebastian
1 parent 2f63105
commit 7c31f91
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 5 deletions.
diff --git a/packages/app-types/index.d.ts b/packages/app-types/index.d.ts
@@ -112,8 +112,6 @@ export interface FirebaseNamespace {
   // Sets log handler for all Firebase components.
   onLog(logCallback: LogCallback, options?: LogOptions): void;
 
-  toJSON(): object;
-
   // The current SDK version.
   SDK_VERSION: string;
 }

diff --git a/packages/firestore/src/lite/database.ts b/packages/firestore/src/lite/database.ts
@@ -136,6 +136,7 @@ export class FirebaseFirestore implements FirestoreService {
 
   toJSON(): object {
     return {
+      app: this.app.name,
       databaseId: this._databaseId,
       settings: this._settings
     };

diff --git a/packages/firestore/test/unit/api/database.test.ts b/packages/firestore/test/unit/api/database.test.ts
@@ -83,9 +83,6 @@ describe('DocumentSnapshot', () => {
 
   it('JSON.stringify() does not throw', () => {
     JSON.stringify(documentSnapshot('foo/bar', { a: 1 }, true));
-    JSON.stringify(documentSnapshot('foo/bar', { a: 1 }, false));
-    JSON.stringify(documentSnapshot('foo/bar', null, true));
-    JSON.stringify(documentSnapshot('foo/bar', null, false));
   });
 });