Skip to content

Commit

Permalink
Add exp code owners (#3882)
Browse files Browse the repository at this point in the history
* add code owner for exp packages

* add code owners for exp packages; exclude auth-exp from the release process for now
  • Loading branch information
Feiyang1 authored Oct 6, 2020
1 parent 0e308b6 commit 769f0e7
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 1 deletion.
8 changes: 8 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
Original file line number Diff line number Diff line change
Expand Up @@ -92,3 +92,11 @@ scripts/docgen/content-sources/ @firebase/firebase-techwriters @firebase/jssdk-g
packages-exp/auth-exp @avolkovi @samhorlbeck @firebase/jssdk-global-approvers
packages-exp/auth-types-exp @avolkovi @samhorlbeck @firebase/jssdk-global-approvers
packages-exp/auth-compat-exp @avolkovi @samhorlbeck @firebase/jssdk-global-approvers

# Installations-Exp Code
packages/installations-exp @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers
packages/installations-types-exp @andirayo @ChaoqunCHEN @firebase/jssdk-global-approvers

# Perf-Exp Code
packages/performance-exp @alikn @zijianjoy @firebase/jssdk-global-approvers
packages/performance-types-exp @alikn @zijianjoy @firebase/jssdk-global-approvers
5 changes: 4 additions & 1 deletion scripts/exp/release.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,13 @@ async function publishExpPackages({ dryRun }: { dryRun: boolean }) {
await buildPackages();

// path to exp packages
const packagePaths = await mapWorkspaceToPackages([
let packagePaths = await mapWorkspaceToPackages([
`${projectRoot}/packages-exp/*`
]);

// exclude auth packages until we are ready to release
packagePaths = packagePaths.filter(path => !path.includes('auth'));

packagePaths.push(`${projectRoot}/packages/firestore`);

/**
Expand Down

0 comments on commit 769f0e7

Please sign in to comment.