Fixes #1450: ThenableReference should extend Promise, not PromiseLike. (

#1462) Since we implement .catch(), we should extend Promise.
firebase · Jan 9, 2019 · 0b42ff8 · 0b42ff8
1 parent 1e7771c
commit 0b42ff8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/database-types/index.d.ts b/packages/database-types/index.d.ts
@@ -125,7 +125,7 @@ export interface ServerValue {
   };
 }
 
-export interface ThenableReference extends Reference, PromiseLike<Reference> {}
+export interface ThenableReference extends Reference, Promise<Reference> {}
 
 export function enableLogging(
   logger?: boolean | ((a: string) => any),

diff --git a/packages/firebase/index.d.ts b/packages/firebase/index.d.ts
@@ -585,7 +585,7 @@ declare namespace firebase.database {
 
   interface ThenableReference
     extends firebase.database.Reference,
-      PromiseLike<any> {}
+      Promise<Reference> {}
 
   function enableLogging(
     logger?: boolean | ((a: string) => any),