Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import regression when mixing 6.7.0 with earlier Firebase versions #6050

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

paulb777
Copy link
Member

Fix #6047

Repo-relative imports don't work from .h files that are imported from other pods (even though it works in development pods.)

Copy link
Member

@ryanwilson ryanwilson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for tracking this down - do we want to merge into master first then cherry-pick? Or directly to the release branch?

Please remove .travis.yml change after it passes.

@paulb777
Copy link
Member Author

I'll remove the .travis.yml change after tests pass. Then merge to release branch, retag, publish, and merge to master.

@paulb777
Copy link
Member Author

GHA is sick and not starting CI.

travis ran successfully at https://travis-ci.org/github/firebase/firebase-ios-sdk/builds/708376422

The messaging quickstart builds with a published version of GoogleUtilities on https://github.com/firebase/SpecsStaging

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants