Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deprecated keyWindow to new API #14048

Merged
merged 2 commits into from
Nov 8, 2024
+1 −7
Merged

Change deprecated keyWindow to new API #14048

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ce1afa
Change deprecated keyWindow to new API
themiswang Nov 7, 2024
3845f72
find a even better api
themiswang Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions FirebasePerformance/Sources/Instrumentation/UIKit/FPRUIViewControllerInstrument.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,15 +69,9 @@ void InstrumentViewDidAppear(FPRUIViewControllerInstrument *instrument,

// This has to be called on the main thread and so it's done here instead of in
// FPRScreenTraceTracker.
// TODO(#13067): Replace keyWindow usage (deprecated in iOS and unavailable in visionOS).
#if !defined(TARGET_OS_VISION) || !TARGET_OS_VISION
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wdeprecated-declarations"
if ([((UIViewController *)_self).view isDescendantOfView:FPRSharedApplication().keyWindow]) {
#pragma clang diagnostic pop
if (FPRSharedApplication() && ((UIViewController *)_self).view.window.keyWindow) {
[[FPRScreenTraceTracker sharedInstance] viewControllerDidAppear:_self];
}
#endif
}];
}

Expand Down
Loading