When token fetch fails, return the failure reason to the client. #14014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when token fetch fails, a generic and misleading message like this is shown: > Invalid fetch response, expected 'token' or 'Error' key After this PR, the actual failure reason returned from the server will be logged and returned to the client.
Generated by 🚫 Danger |
ncooke3
approved these changes
Nov 2, 2024
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when token fetch fails, a generic and misleading message like this is shown:
After this PR, the actual failure reason returned from the server will be logged and returned to the client.
This is expected to fix issue #13997.
#no-changelog