Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auth] Use constants for 'supportsSecureCoding' implementation #13988

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented Oct 29, 2024

The static var does not compile in Swift 6 due to shared mutable state. To
work around, you can use a constant or a computed var. To standardize things,
I chose to go with a constant.

This should not affect how the types conform to NSSecureCoding as a constant
can be used to implement a protocol getter-only property. See
https://stackoverflow.com/a/38281420/9331576

#no-changelog

@ncooke3 ncooke3 merged commit f061a83 into main Oct 29, 2024
55 checks passed
@ncooke3 ncooke3 deleted the nc/auth-coding branch October 29, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants