-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SessionToken persistence implementation #13684
Merged
Merged
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
fb33aca
SessionToken persistence implementation
tom-andersen c71d4d3
Style
tom-andersen cd5ac18
Add tests
tom-andersen bc4d0b3
Fix
tom-andersen d0543e0
Fix
tom-andersen 134316b
Fix
tom-andersen b81a97b
Fix test
tom-andersen 4d75ab2
Fix test
tom-andersen 2aa3684
Pod update
tom-andersen 1e83db5
Fix
tom-andersen 0d59fdd
run sync script
wu-hui 00edd58
Add changelog entry
tom-andersen 051d84b
Review fixes
tom-andersen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/** | ||
* @license | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#ifndef FIRESTORE_CORE_SRC_LOCAL_GLOBALS_CACHE_H_ | ||
#define FIRESTORE_CORE_SRC_LOCAL_GLOBALS_CACHE_H_ | ||
|
||
#include "Firestore/core/src/nanopb/byte_string.h" | ||
|
||
namespace firebase { | ||
namespace firestore { | ||
namespace local { | ||
|
||
using nanopb::ByteString; | ||
tom-andersen marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
/** | ||
* General purpose cache for global values. | ||
* | ||
* Global state that cuts across components should be saved here. Following are | ||
* contained herein: | ||
* | ||
* `sessionToken` tracks server interaction across Listen and Write streams. | ||
* This facilitates cache synchronization and invalidation. | ||
*/ | ||
class GlobalsCache { | ||
public: | ||
virtual ~GlobalsCache() = default; | ||
|
||
/** | ||
* Gets session token. | ||
*/ | ||
virtual ByteString GetSessionToken() const = 0; | ||
|
||
/** | ||
* Sets session token. | ||
*/ | ||
virtual void SetSessionToken(const ByteString& session_token) = 0; | ||
}; | ||
|
||
} // namespace local | ||
} // namespace firestore | ||
} // namespace firebase | ||
|
||
#endif // FIRESTORE_CORE_SRC_LOCAL_GLOBALS_CACHE_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,57 @@ | ||
/* | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#include <string> | ||
|
||
#include "Firestore/core/src/local/leveldb_globals_cache.h" | ||
#include "Firestore/core/src/local/leveldb_key.h" | ||
#include "Firestore/core/src/local/leveldb_persistence.h" | ||
|
||
namespace firebase { | ||
namespace firestore { | ||
namespace local { | ||
|
||
namespace { | ||
|
||
const char* kSessionToken = "session_token"; | ||
|
||
} | ||
|
||
LevelDbGlobalsCache::LevelDbGlobalsCache(LevelDbPersistence* db) | ||
: db_(NOT_NULL(db)) { | ||
} | ||
|
||
ByteString LevelDbGlobalsCache::GetSessionToken() const { | ||
auto key = LevelDbGlobalKey::Key(kSessionToken); | ||
|
||
std::string encoded; | ||
auto done = db_->current_transaction()->Get(key, &encoded); | ||
|
||
if (!done.ok()) { | ||
return ByteString(); | ||
} | ||
|
||
return ByteString(encoded); | ||
} | ||
|
||
void LevelDbGlobalsCache::SetSessionToken(const ByteString& session_token) { | ||
auto key = LevelDbGlobalKey::Key(kSessionToken); | ||
db_->current_transaction()->Put(key, session_token.ToString()); | ||
} | ||
|
||
} // namespace local | ||
} // namespace firestore | ||
} // namespace firebase |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,52 @@ | ||
/* | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#ifndef FIRESTORE_CORE_SRC_LOCAL_LEVELDB_GLOBALS_CACHE_H_ | ||
#define FIRESTORE_CORE_SRC_LOCAL_LEVELDB_GLOBALS_CACHE_H_ | ||
|
||
#include "Firestore/core/src/local/globals_cache.h" | ||
|
||
namespace firebase { | ||
namespace firestore { | ||
namespace local { | ||
|
||
class LevelDbPersistence; | ||
|
||
class LevelDbGlobalsCache : public GlobalsCache { | ||
public: | ||
/** Creates a new bundle cache in the given LevelDB. */ | ||
explicit LevelDbGlobalsCache(LevelDbPersistence* db); | ||
|
||
/** | ||
* Gets session token. | ||
*/ | ||
ByteString GetSessionToken() const override; | ||
|
||
/** | ||
* Sets session token. | ||
*/ | ||
void SetSessionToken(const ByteString& session_token) override; | ||
|
||
private: | ||
// The LevelDbGlobalsCache is owned by LevelDbPersistence. | ||
LevelDbPersistence* db_ = nullptr; | ||
}; | ||
|
||
} // namespace local | ||
} // namespace firestore | ||
} // namespace firebase | ||
|
||
#endif // FIRESTORE_CORE_SRC_LOCAL_LEVELDB_GLOBALS_CACHE_H_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
/* | ||
* Copyright 2024 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
#include "Firestore/core/src/local/memory_globals_cache.h" | ||
|
||
namespace firebase { | ||
namespace firestore { | ||
namespace local { | ||
|
||
ByteString MemoryGlobalsCache::GetSessionToken() const { | ||
return session_token_; | ||
} | ||
|
||
void MemoryGlobalsCache::SetSessionToken(const ByteString& session_token) { | ||
session_token_ = session_token; | ||
} | ||
|
||
} // namespace local | ||
} // namespace firestore | ||
} // namespace firebase |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change missed yesterday's code freeze. Please move to unreleased.