Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vertex AI] Add Decodable conformance for FunctionResponse #13606

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

andrewheard
Copy link
Contributor

Added decoding support for ModelContent.Part.functionResponse. Although FunctionResponse parts are never returned from the backend, Decodable conformance allows this type to be serialized/deserialized from disk. See #13593 for an example use case.

#no-changelog

Copy link
Member

@ncooke3 ncooke3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Does this need a release note?

@andrewheard
Copy link
Contributor Author

Nice! Does this need a release note?

@ncooke3 I'm not certain that it's noteworthy enough for a release note but to err on the side of caution I've added one now (easier to prune it out later than remember to add it later).

@andrewheard andrewheard merged commit 3e2c79d into main Sep 9, 2024
32 checks passed
@andrewheard andrewheard deleted the ah/vertex-func-resp-decode branch September 9, 2024 19:36
@firebase firebase locked and limited conversation to collaborators Oct 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants