Add -Wno-error=redundant-move
to cmake builds
#13582
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
-Wno-error=redundant-move
to avoid failing the build due to unnecessarystd::move()
calls. It is common practice to usestd::move()
liberally, even if it's not strictly beneficial, to ensure that a type is moved if its definition is ever changed to not be trivially movable. Therefore, it doesn't make sense to fail the build due to unnecessarystd::move()
calls.This fixes the following compiler error:
The compiler in use in this case was reported by cmake as
-- The CXX compiler identification is GNU 13.2.0
#no-changelog