Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Collections Coding in FunctionsSerializer #13419

Merged

Commits on Jul 29, 2024

  1. Consistent Collections Coding in FunctionsSerializer

    * If `FunctionsSerializer` is given an object of unsupported type to encode, it throws an error
    * However, if that object is contained in a dictionary, `FunctionsSerializer` crashes the app because of a force-unwrap
    * The change fixes this inconsistency
    * Additionally, array decoding no longer uses an `if-let` and instead inserts the optional value `as Any`
    * Overall, this change achieves consistency in encoding and decoding of collections: Any non-codable element fails the operation, without crashing the app or resulting in missing elements
    * New tests were added to check these scenarios
    yakovmanshin committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    8892b86 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Configuration menu
    Copy the full SHA
    3ab4e0a View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    aa71e1c View commit details
    Browse the repository at this point in the history