Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Carthage versions for M148 / 10.27.0 #13030

Merged
merged 1 commit into from
May 29, 2024
Merged

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 29, 2024

#no-changelog

@ncooke3 ncooke3 merged commit 3fa4aa8 into main May 29, 2024
38 checks passed
@ncooke3 ncooke3 deleted the nc/carthage-m148 branch May 29, 2024 17:03
cgrindel-self-hosted-renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Jul 2, 2024
….28.1" (#1132)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
|
[firebase/firebase-ios-sdk](https://togithub.com/firebase/firebase-ios-sdk)
| minor | `from: "10.26.0"` -> `from: "10.28.1"` |

---

### Release Notes

<details>
<summary>firebase/firebase-ios-sdk (firebase/firebase-ios-sdk)</summary>

###
[`v10.28.1`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.28.1):
Firebase Apple 10.28.1

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.28.0...10.28.1)

The Firebase Apple SDK (10.28.1) is now available.

This release is only available for CocoaPods and Swift Package Manager
and only changes Firebase Crashlytics.

See details at [Firebase Apple SDK release
notes](https://firebase.google.com/support/release-notes/ios#10.28.1).

#### What's Changed

- \[Crashlytics] Reverted "Add SIGTERM support
([#&#8203;12881](https://togithub.com/firebase/firebase-ios-sdk/issues/12881))"
introduced in version 10.27.0
([#&#8203;13117](https://togithub.com/firebase/firebase-ios-sdk/issues/13117)).

**Full Changelog**:
firebase/firebase-ios-sdk@10.28.0...10.28.1

###
[`v10.28.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.28.0):
Firebase Apple 10.28.0

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.27.0...10.28.0)

The Firebase Apple SDK (10.28.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.28.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- \[Remote Config] Attempt to reduce int. tests flakes by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13019](https://togithub.com/firebase/firebase-ios-sdk/pull/13019)
- Removed Unused Availability Checks by
[@&#8203;yakovmanshin](https://togithub.com/yakovmanshin) in
[https://github.com/firebase/firebase-ios-sdk/pull/13023](https://togithub.com/firebase/firebase-ios-sdk/pull/13023)
- Fix fireperf exception by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12991](https://togithub.com/firebase/firebase-ios-sdk/pull/12991)
- \[Release] Carthage versions for M148 / 10.27.0 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13030](https://togithub.com/firebase/firebase-ios-sdk/pull/13030)
- \[Release] Update versions for Release 10.28.0 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13033](https://togithub.com/firebase/firebase-ios-sdk/pull/13033)
- Fix deprecated typo by
[@&#8203;michalsrutek](https://togithub.com/michalsrutek) in
[https://github.com/firebase/firebase-ios-sdk/pull/13037](https://togithub.com/firebase/firebase-ios-sdk/pull/13037)
- Make sure rollouts logging queue is not nil by
[@&#8203;themiswang](https://togithub.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/13058](https://togithub.com/firebase/firebase-ios-sdk/pull/13058)
- \[Infra] Get testing tag from latest tag merged to main by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13061](https://togithub.com/firebase/firebase-ios-sdk/pull/13061)
- \[Infra] Quick fix for NOTICES generation by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13062](https://togithub.com/firebase/firebase-ios-sdk/pull/13062)
- \[Vertex AI] Add simple integration tests by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13075](https://togithub.com/firebase/firebase-ios-sdk/pull/13075)
- Replace SystemConfiguration with a more recent Apple provided network
monitoring API. by [@&#8203;visumickey](https://togithub.com/visumickey)
in
[https://github.com/firebase/firebase-ios-sdk/pull/13091](https://togithub.com/firebase/firebase-ios-sdk/pull/13091)
- \[Vertex AI] Add environment variable to control integration tests by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13095](https://togithub.com/firebase/firebase-ios-sdk/pull/13095)
- \[Vertex AI] Update samples/docs to use `gemini-1.5-flash` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13099](https://togithub.com/firebase/firebase-ios-sdk/pull/13099)
- \[Vertex AI] Add support for compiling on tvOS by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13090](https://togithub.com/firebase/firebase-ios-sdk/pull/13090)
- \[Vertex AI] Add CI for visionOS by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13092](https://togithub.com/firebase/firebase-ios-sdk/pull/13092)
- Early return for rollouts write errors by
[@&#8203;themiswang](https://togithub.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/13103](https://togithub.com/firebase/firebase-ios-sdk/pull/13103)
- \[Vertex AI] Add CHANGELOG for tvOS/visionOS community support by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13105](https://togithub.com/firebase/firebase-ios-sdk/pull/13105)
- Changelogs 10.28.0 by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/13111](https://togithub.com/firebase/firebase-ios-sdk/pull/13111)
- \[Docs] Update Crashlytics/CHANGELOG.md by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13112](https://togithub.com/firebase/firebase-ios-sdk/pull/13112)
- Add `FIRAppCheckTokenProtocol` for use in `FIRAppCheckProtocol` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13035](https://togithub.com/firebase/firebase-ios-sdk/pull/13035)
- Analytics 10.28.0 by [@&#8203;pcfba](https://togithub.com/pcfba) in
[https://github.com/firebase/firebase-ios-sdk/pull/13116](https://togithub.com/firebase/firebase-ios-sdk/pull/13116)
- Import `Foundation` in `FIRAppCheckTokenProtocol` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13121](https://togithub.com/firebase/firebase-ios-sdk/pull/13121)

#### New Contributors

- [@&#8203;michalsrutek](https://togithub.com/michalsrutek) made their
first contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/13037](https://togithub.com/firebase/firebase-ios-sdk/pull/13037)

**Full Changelog**:
firebase/firebase-ios-sdk@10.27.0...10.28.0

###
[`v10.27.0`](https://togithub.com/firebase/firebase-ios-sdk/releases/tag/10.27.0):
Firebase Apple 10.27.0

[Compare
Source](https://togithub.com/firebase/firebase-ios-sdk/compare/10.26.0...10.27.0)

The Firebase Apple SDK (10.27.0) is now available. For more details, see
the [Firebase Apple SDK release
notes.](https://firebase.google.com/support/release-notes/ios#10.27.0)

To install this SDK, see [Add Firebase to your
project.](https://firebase.google.com/docs/ios/setup)

#### What's Changed

- Disable failing ObjC Performance quickstart on CI by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12853](https://togithub.com/firebase/firebase-ios-sdk/pull/12853)
- Gracefully fail rollout write by
[@&#8203;themiswang](https://togithub.com/themiswang) in
[https://github.com/firebase/firebase-ios-sdk/pull/12863](https://togithub.com/firebase/firebase-ios-sdk/pull/12863)
- \[Release] Carthage updates for 10.25.0 by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12871](https://togithub.com/firebase/firebase-ios-sdk/pull/12871)
- \[Release] Update Package.swift for 10.26.0 by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12873](https://togithub.com/firebase/firebase-ios-sdk/pull/12873)
- Update versions for Release 10.27.0 by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12875](https://togithub.com/firebase/firebase-ios-sdk/pull/12875)
- Add SIGTERM support by [@&#8203;naftaly](https://togithub.com/naftaly)
in
[https://github.com/firebase/firebase-ios-sdk/pull/12881](https://togithub.com/firebase/firebase-ios-sdk/pull/12881)
- \[Release] Update CHANGELOG.md for
[#&#8203;12881](https://togithub.com/firebase/firebase-ios-sdk/issues/12881)
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12885](https://togithub.com/firebase/firebase-ios-sdk/pull/12885)
- Improve/use shorthand syntax for unwrapping optionals and fix typos by
[@&#8203;sheikhbayazid](https://togithub.com/sheikhbayazid) in
[https://github.com/firebase/firebase-ios-sdk/pull/12369](https://togithub.com/firebase/firebase-ios-sdk/pull/12369)
- Stop CI on Swift podspecs by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12895](https://togithub.com/firebase/firebase-ios-sdk/pull/12895)
- \[Release Tooling] Add functionality to build dynamic frameworks by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12890](https://togithub.com/firebase/firebase-ios-sdk/pull/12890)
- \[InAppMessaging] Fix
[#&#8203;12882](https://togithub.com/firebase/firebase-ios-sdk/issues/12882)
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12910](https://togithub.com/firebase/firebase-ios-sdk/pull/12910)
- Improve Usage of SQLITE_OPEN_FILEPROTECTION_NONE in
FIRMessagingRmqManager.m by
[@&#8203;doganaltinbas](https://togithub.com/doganaltinbas) in
[https://github.com/firebase/firebase-ios-sdk/pull/12909](https://togithub.com/firebase/firebase-ios-sdk/pull/12909)
- \[Release] Update changelog to reflect
[#&#8203;12900](https://togithub.com/firebase/firebase-ios-sdk/issues/12900)
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12915](https://togithub.com/firebase/firebase-ios-sdk/pull/12915)
- \[RTDB] Use NSURLSessionWebSocket instead of SocketRocket where
possible by [@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12894](https://togithub.com/firebase/firebase-ios-sdk/pull/12894)
- \[InAppMessaging] Follow-up to
[#&#8203;12910](https://togithub.com/firebase/firebase-ios-sdk/issues/12910)
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12917](https://togithub.com/firebase/firebase-ios-sdk/pull/12917)
- \[Release] Update FIAM changelog to reflect 10.26.0 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12919](https://togithub.com/firebase/firebase-ios-sdk/pull/12919)
- Update FirebaseAppCheck's FirebaseCore dependency by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12925](https://togithub.com/firebase/firebase-ios-sdk/pull/12925)
- \[Firestore] Cleanup compilation guards for building on older SDKs by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12936](https://togithub.com/firebase/firebase-ios-sdk/pull/12936)
- \[Messaging] Cleanup compilation guards for building on older SDKs by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12935](https://togithub.com/firebase/firebase-ios-sdk/pull/12935)
- \[Infra] Attempt to fix
[#&#8203;12769](https://togithub.com/firebase/firebase-ios-sdk/issues/12769)
by [@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12938](https://togithub.com/firebase/firebase-ios-sdk/pull/12938)
- \[NFC] Remove outdated comment by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12940](https://togithub.com/firebase/firebase-ios-sdk/pull/12940)
- \[FIAM] Cleanup compilation guards for building on older SDKs by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12937](https://togithub.com/firebase/firebase-ios-sdk/pull/12937)
- \[Infra] Clean up visionOS conditionals by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12934](https://togithub.com/firebase/firebase-ios-sdk/pull/12934)
- \[Infra] Re-enable 'zip / quickstart_framework_firestore' job by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/12943](https://togithub.com/firebase/firebase-ios-sdk/pull/12943)
- Merge `release-10.26` into `main` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12955](https://togithub.com/firebase/firebase-ios-sdk/pull/12955)
- \[Vertex AI] Update sample README for `main` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12956](https://togithub.com/firebase/firebase-ios-sdk/pull/12956)
- \[Vertex AI] Rename `FirebaseVertexAI-Docs.podspec` to avoid CI by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12958](https://togithub.com/firebase/firebase-ios-sdk/pull/12958)
- \[Vertex AI] Align text and add close keyboard function in Sample
Project by [@&#8203;1998code](https://togithub.com/1998code) in
[https://github.com/firebase/firebase-ios-sdk/pull/12887](https://togithub.com/firebase/firebase-ios-sdk/pull/12887)
- Fix VisionOS and WatchOS CI by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12966](https://togithub.com/firebase/firebase-ios-sdk/pull/12966)
- use correct variable by
[@&#8203;morganchen12](https://togithub.com/morganchen12) in
[https://github.com/firebase/firebase-ios-sdk/pull/12971](https://togithub.com/firebase/firebase-ios-sdk/pull/12971)
- Update versions in `FirebaseVertexAI-Docs.not_podspec` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12973](https://togithub.com/firebase/firebase-ios-sdk/pull/12973)
- Bump rexml from 3.2.5 to 3.2.8 by
[@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/firebase/firebase-ios-sdk/pull/12978](https://togithub.com/firebase/firebase-ios-sdk/pull/12978)
- Bump rexml from 3.2.5 to 3.2.8 in /.github/actions/notices_generation
by [@&#8203;dependabot](https://togithub.com/dependabot) in
[https://github.com/firebase/firebase-ios-sdk/pull/12980](https://togithub.com/firebase/firebase-ios-sdk/pull/12980)
- \[Vertex AI] Update samples/docs to use
`gemini-1.5-flash-preview-0514` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/12979](https://togithub.com/firebase/firebase-ios-sdk/pull/12979)
- Crashlytics dispatch Rollouts writes async to prevent crashes by
[@&#8203;samedson](https://togithub.com/samedson) in
[https://github.com/firebase/firebase-ios-sdk/pull/12977](https://togithub.com/firebase/firebase-ios-sdk/pull/12977)
- Update retry logic for flaky tests by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12998](https://togithub.com/firebase/firebase-ios-sdk/pull/12998)
- Deprecation warning for FDL by
[@&#8203;paulb777](https://togithub.com/paulb777) in
[https://github.com/firebase/firebase-ios-sdk/pull/12999](https://togithub.com/firebase/firebase-ios-sdk/pull/12999)
- \[Release] Prep changelogs for 10.27.0 / M148 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13005](https://togithub.com/firebase/firebase-ios-sdk/pull/13005)
- Analytics 10.27.0 by
[@&#8203;tsunghung](https://togithub.com/tsunghung) in
[https://github.com/firebase/firebase-ios-sdk/pull/13006](https://togithub.com/firebase/firebase-ios-sdk/pull/13006)
- \[Vertex AI] Add error message for Firebase ML API not enabled by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13007](https://togithub.com/firebase/firebase-ios-sdk/pull/13007)
- \[Vertex AI] Log server error responses without `-FIRDebugEnabled` by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13009](https://togithub.com/firebase/firebase-ios-sdk/pull/13009)
- \[Vertex AI] Add CHANGELOG entry for 10.27.0 by
[@&#8203;andrewheard](https://togithub.com/andrewheard) in
[https://github.com/firebase/firebase-ios-sdk/pull/13010](https://togithub.com/firebase/firebase-ios-sdk/pull/13010)
- \[Release] Update FirestoreInternal binary for 10.27.0 / M148 by
[@&#8203;ncooke3](https://togithub.com/ncooke3) in
[https://github.com/firebase/firebase-ios-sdk/pull/13013](https://togithub.com/firebase/firebase-ios-sdk/pull/13013)

#### New Contributors

- [@&#8203;naftaly](https://togithub.com/naftaly) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12881](https://togithub.com/firebase/firebase-ios-sdk/pull/12881)
- [@&#8203;sheikhbayazid](https://togithub.com/sheikhbayazid) made their
first contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12369](https://togithub.com/firebase/firebase-ios-sdk/pull/12369)
- [@&#8203;doganaltinbas](https://togithub.com/doganaltinbas) made their
first contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12909](https://togithub.com/firebase/firebase-ios-sdk/pull/12909)
- [@&#8203;1998code](https://togithub.com/1998code) made their first
contribution in
[https://github.com/firebase/firebase-ios-sdk/pull/12887](https://togithub.com/firebase/firebase-ios-sdk/pull/12887)

**Full Changelog**:
firebase/firebase-ios-sdk@10.25.0...10.27.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config help](https://togithub.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDkuNCIsInVwZGF0ZWRJblZlciI6IjM2LjEwOS40IiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants