Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Usage of SQLITE_OPEN_FILEPROTECTION_NONE in FIRMessagingRmqManager.m #12909

Merged
merged 3 commits into from
May 7, 2024

Conversation

doganaltinbas
Copy link
Contributor

#12900

Testing

  • I ran tests locally ✅

Copy link

google-cla bot commented May 7, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@doganaltinbas doganaltinbas changed the title Update FIRMessagingRmqManager.m Improve Usage of SQLITE_OPEN_FILEPROTECTION_NONE in FIRMessagingRmqManager.m May 7, 2024
@doganaltinbas
Copy link
Contributor Author

I just signed the CLA. Could I get help from a maintainer to rerun the workflow?
Thanks.

@ncooke3
Copy link
Member

ncooke3 commented May 7, 2024

Thanks, @doganaltinbas! To fix the check failure, could you please run the formatter on the modified file?

See here: https://github.com/firebase/firebase-ios-sdk/tree/main?tab=readme-ov-file#code-formatting

e.g. scripts/style.h FirebaseMessaging/Sources/FIRMessagingRmqManager.m

@doganaltinbas
Copy link
Contributor Author

Thanks @ncooke3, I ran the script and pushed the commit.

@ncooke3 ncooke3 requested a review from leojaygoogle May 7, 2024 18:03
@ncooke3 ncooke3 merged commit 96b6891 into firebase:main May 7, 2024
69 checks passed
@firebase firebase locked and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants