Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gracefully fail rollout write #12863

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Gracefully fail rollout write #12863

merged 2 commits into from
Apr 29, 2024

Conversation

themiswang
Copy link
Contributor

@themiswang themiswang commented Apr 29, 2024 •
edited
Loading

per #12859

#no-changelog

samedson
samedson approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@samedson samedson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion

@themiswang themiswang merged commit b5c4044 into main Apr 29, 2024
69 checks passed
@themiswang themiswang deleted the rolloutGracefulWrite branch April 29, 2024 22:18
@paulb777 paulb777 added this to the 10.27.0 - M148 milestone May 21, 2024
@paulb777 paulb777 mentioned this pull request May 21, 2024
Closed
@firebase firebase locked and limited conversation to collaborators May 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@samedson samedson samedson approved these changes

Assignees
No one assigned
Labels
api: crashlytics
Projects
None yet
Milestone
10.27.0 - M148
Development

Successfully merging this pull request may close these issues.
4 participants
@themiswang @samedson @paulb777 @google-oss-bot