[Sessions] Migrate to GoogleUtilities's storage container #12752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 Danger |
paulb777
approved these changes
Apr 11, 2024
|
Will do a separate changelog PR for all of the products this migration applies to. |
|
cc: @themiswang @visumickey Feel free to leave comments and I'll address in a follow-up PR. |
themiswang
reviewed
Apr 11, 2024
Thank you for fixing it Nick! LGTM and just a nit comment. |
|
The changes look good to me. But similar to the performance situation, the configs are cached in NSUserDefaults and this change could impact that. Luckily there are no config changes that are happening for sessions that makes this change safer. So, LGTM. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.