Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade grpc to 1.62.0 for cocoapods #12400

Closed
wants to merge 4 commits into from
Closed

Upgrade grpc to 1.62.0 for cocoapods #12400

wants to merge 4 commits into from

Conversation

HannahShiSFB
Copy link

@HannahShiSFB HannahShiSFB commented Feb 18, 2024 •
edited
Loading

test errors in #12398

@HannahShiSFB HannahShiSFB marked this pull request as ready for review February 18, 2024 02:22
@HannahShiSFB
Copy link
Author

passed locally.
@wu-hui could you take a look? Thanks a lot

@HannahShiSFB HannahShiSFB changed the title Upgrade grpc to 1.61.1 for cocoapods Upgrade grpc to 1.62.0 for cocoapods Feb 21, 2024
@HannahShiSFB
Copy link
Author

Looks like the boring ssl fix didn't make into 1.61, upgrade to 1.62.0 should work.

@HannahShiSFB
Copy link
Author

@wu-hui It builds now.
For test failures in "firestore / cmake-prod-db", I have no idea.
For test failure in "firestore / xcodebuild" at to_string_test.cc:53, it's likely related to abseil upgrade.

@paulb777
Copy link
Member

Close in favor of #12398?

@paulb777
Copy link
Member

Closing in favor of #12398

@paulb777 paulb777 closed this Mar 12, 2024
@firebase firebase locked and limited conversation to collaborators Apr 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HannahShiSFB @paulb777