Update travis to use CocoaPods 1.5.2 #1103

paulb777 · 2018-04-14T14:14:05Z

Update to CocoaPods 1.5.2
Add CODE_SIGNING_ALLOWED=YES to xcodebuild command to work around TravisCI fails to boot Simulator with CocoaPods 1.5.x CocoaPods/CocoaPods#7734
Remove workarounds for Without use_frameworks!, "implemented in both" loader errors running tests CocoaPods/CocoaPods#7592 that are no longer needed with CocoaPods 1.5.x
Run on an iPhone 8 Plus simulator instead of iPhone 7
Force full travis build on Gemfile.lock update
Restore Firestore/Example/Podfile from before Prepare Firestore for use as a static library #1210 static library build workarounds
Add -all_load to Firestore Example project build so that all C++ are linked in and satisfy linker dependencies from tests

paulb777 · 2018-04-14T15:11:58Z

ios and tvOS tests failing with

2018-04-14 15:03:20.671 xcodebuild[7023:18568] iOSSimulator: task_name_for_pid(mach_task_self(), 8340, &task) returned 5
2018-04-14 15:03:20.675 xcodebuild[7023:18568] iOSSimulator: Falling back to DISPATCH_SOURCE_TYPE_PROC
2018-04-14 15:03:21.075 xcodebuild[7023:14859] Error Domain=IDETestOperationsObserverErrorDomain Code=6 "Early unexpected exit, operation never finished bootstrapping - no restart will be attempted" UserInfo={NSLocalizedDescription=Early unexpected exit, operation never finished bootstrapping - no restart will be attempted}
2018-04-14 15:03:21.076 xcodebuild[7023:14859] Error Domain=IDETestOperationsObserverErrorDomain Code=6 "Early unexpected exit, operation never finished bootstrapping - no restart will be attempted" UserInfo={NSLocalizedDescription=Early unexpected exit, operation never finished bootstrapping - no restart will be attempted}
2018-04-14 15:03:21.076 xcodebuild[7023:14859] Error Domain=IDETestOperationsObserverErrorDomain Code=6 "Early unexpected exit, operation never finished bootstrapping - no restart will be attempted" UserInfo={NSLocalizedDescription=Early unexpected exit, operation never finished bootstrapping - no restart will be attempted}
2018-04-14 15:03:21.076 xcodebuild[7023:14859] Error Domain=IDETestOperationsObserverErrorDomain Code=6 "Early unexpected exit, operation never finished bootstrapping - no restart will be attempted" UserInfo={NSLocalizedDescription=Early unexpected exit, operation never finished bootstrapping - no restart will be attempted}

wilhuff · 2018-04-17T22:06:21Z

@paulb777, is this in a reviewable state? Your comments here indicate this isn't working.

paulb777 · 2018-04-17T22:20:25Z

@wilhuff - It needs more investigation before being reviewable. I'm unlikely to be able to continue on it in the next few weeks. Anyone else is welcome to pick it up. :)

paulb777 · 2018-05-12T01:06:22Z

Adding CODE_SIGNING_ALLOWED=YES to the Firebase builds gets them to go, but it looks like there's another issue with the Firestore builds that it can't find FirebaseAuth.

paulb777 · 2018-05-13T00:29:46Z

Seem to be getting close - but for some reason the reorganized build causes 21 Firestore unit test failures ....

FSTLocalSerializerTests
testEncodesMutationBatch, (([self.serializer encodedMutationBatch:model]) equal to (batchProto)) failed: ("<FSTPBWriteBatch 0x608000203820>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Local/FSTLocalSerializerTests.mm:123

XCTAssertEqualObjects([self.serializer encodedMutationBatch:model], batchProto);
FSTMutationBatch *decoded = [self.serializer decodedMutationBatch:batchProto];

testEncodesQueryData, (([self.serializer encodedQueryData:queryData]) equal to (expected)) failed: ("<FSTPBTarget 0x60c0000d9240>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Local/FSTLocalSerializerTests.mm:186

XCTAssertEqualObjects([self.serializer encodedQueryData:queryData], expected);
FSTQueryData *decoded = [self.serializer decodedQueryData:expected];

FSTSerializerBetaTests
testEncodesArrayContainsFilter, ((actual) equal to (expected)) failed: ("<GCFSStructuredQuery_Filter 0x60b000030c90>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:499

prop.value.stringValue = @"food";
XCTAssertEqualObjects(actual, expected);
}

testEncodesArrays, ((actualProto) equal to (value)) failed: ("<GCFSValue 0x60e0000d92e0>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:335

XCTAssertEqual(actualProto.valueTypeOneOfCase, type);
XCTAssertEqualObjects(actualProto, value);

testEncodesArrayTransformMutations, ((actualProto) equal to (proto)) failed: ("<GCFSWrite 0x60c000212a40>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:435

GCFSWrite *actualProto = [self.serializer encodedMutation:mutation];
XCTAssertEqualObjects(actualProto, proto);

testEncodesFirstLevelAncestorQueries, ((actualProto) equal to (proto)) failed: ("<GCFSTarget 0x60c000138700>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:739

GCFSTarget *actualProto = [self.serializer encodedTarget:queryData];
XCTAssertEqualObjects(actualProto, proto);

testEncodesFirstLevelKeyQueries, ((actualProto) equal to (proto)) failed: ("<GCFSTarget 0x60c00015ed40>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:739

GCFSTarget *actualProto = [self.serializer encodedTarget:queryData];
XCTAssertEqualObjects(actualProto, proto);

testEncodesLimits, ((actualProto) equal to (proto)) failed: ("<GCFSTarget 0x60c0001d2480>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:739

GCFSTarget *actualProto = [self.serializer encodedTarget:queryData];
XCTAssertEqualObjects(actualProto, proto);

testEncodesMultipleFiltersOnDeeperCollections, ((actualProto) equal to (proto)) failed: ("<GCFSTarget 0x60c0000cfe80>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:739

GCFSTarget *actualProto = [self.serializer encodedTarget:queryData];
XCTAssertEqualObjects(actualProto, proto);

testEncodesNanFilter, ((actualProto) equal to (proto)) failed: ("<GCFSTarget 0x60c00000c040>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:739

GCFSTarget *actualProto = [self.serializer encodedTarget:queryData];
XCTAssertEqualObjects(actualProto, proto);

testEncodesNestedAncestorQueries, ((actualProto) equal to (proto)) failed: ("<GCFSTarget 0x60c00000c640>: {
/Users/travis/build/firebase/firebase-ios-sdk/Firestore/Example/Tests/Remote/FSTSerializerBetaTests.mm:739

GCFSTarget *actualProto = [self.serializer encodedTarget:queryData];
XCTAssertEqualObjects(actualProto, proto);

paulb777 · 2018-05-13T17:16:08Z

Now ready for review. Read the updated description at top for a summary.

wilhuff · 2018-05-13T17:29:42Z

Firestore/Example/Podfile

-  # Test targets are below to avoid problems with duplicate symbols when
-  # building as a static library (see comments below).
-end
+  pod 'FirebaseAuth', :path => '../../'


Did you intend to re-nest these here or is this just a bad merge? How does this work around all the duplicate class warnings we were getting from linking the framework into the example app?

I don't intend to re-nest them. They ONLY get linked into the example app. I added -all_load to the Example app build OTHER_LDFLAGS so that unused C++ functions get linked in. Then the test target doesn't need them to build and finds them at runtime from the app.

paulb777 · 2018-05-13T18:55:42Z

Firestore/Example/Firestore.xcodeproj/project.pbxproj

@@ -1864,6 +1533,10 @@
 				);
 				INFOPLIST_FILE = "Firestore/Firestore-Info.plist";
 				MODULE_NAME = ExampleApp;
+				OTHER_LDFLAGS = (


This is the relevant change not from pod deprecate

pod deprecate doesn't seem to be a thing. Do you mean pod deintegrate?

I'm not sure we're seeing much pain from having the project stored integrated. It does mean that as developers we need to run the same version of cocoapods, but that's pretty easy for us to coordinate within the Firestore team.

Meanwhile as we're migrating to C++ we're constantly changing the project to add C++ tests and remove Objective-C tests. It will be a serious pain to have to pod deintegrate to even be able to read the diffs of those changes.

I get it that pod deintegrated projects are cleaner, but practically speaking they're much more cumbersome. I think we should leave this installed.

Yes I meant pod deintegrate. And undone now.

wilhuff

The interesting parts of this LGTM, however see below.

Meanwhile: I've checked this out and run all the tests (including integration tests) and can verify that this works.

Nice sleuthing, BTW. This turns out to be a better solution even for CocoaPods 1.5.0. With -all_load that workaround wasn't needed even before.

wilhuff · 2018-05-13T23:54:20Z

Firestore/Example/Firestore.xcodeproj/project.pbxproj

@@ -1864,6 +1533,10 @@
 				);
 				INFOPLIST_FILE = "Firestore/Firestore-Info.plist";
 				MODULE_NAME = ExampleApp;
+				OTHER_LDFLAGS = (


pod deprecate doesn't seem to be a thing. Do you mean pod deintegrate?

I'm not sure we're seeing much pain from having the project stored integrated. It does mean that as developers we need to run the same version of cocoapods, but that's pretty easy for us to coordinate within the Firestore team.

Meanwhile as we're migrating to C++ we're constantly changing the project to add C++ tests and remove Objective-C tests. It will be a serious pain to have to pod deintegrate to even be able to read the diffs of those changes.

I get it that pod deintegrated projects are cleaner, but practically speaking they're much more cumbersome. I think we should leave this installed.

wilhuff

LGTM

* Update travis to use CocoaPods 1.5.2 * CODE_SIGNING_ALLOWED=YES * Remove workaround and iPhone 8 * Remove firebase#1210 static library Podfile workaround * Add -all_load to Firestore Example so all C++ is available for tests

googlebot added the cla: yes label Apr 14, 2018

paulb777 closed this Apr 21, 2018

paulb777 reopened this Apr 21, 2018

paulb777 force-pushed the pb-travis-cp15 branch from bbfad48 to bd3ea4f Compare May 9, 2018 17:35

paulb777 changed the title ~~Update travis to use CocoaPods 1.5.0~~ Update travis to use CocoaPods 1.5.2 (WIP) May 9, 2018

paulb777 mentioned this pull request May 11, 2018

TravisCI fails to boot Simulator with CocoaPods 1.5.x CocoaPods/CocoaPods#7734

Closed

paulb777 force-pushed the pb-travis-cp15 branch from bd3ea4f to 635f343 Compare May 12, 2018 00:37

paulb777 added 8 commits May 12, 2018 17:13

Update travis to use CocoaPods 1.5.0

6fead8c

Update to CocoaPods 1.5.2

58cd683

CODE_SIGNING_ALLOWED=YES

ad5234c

Remove workaround and iPhone 8

20cdd7e

debugging travis

9568396

debugging travis

83c1cca

Remove static library workaround

70c5c36

deintegrate Firestore.xcodeproj

4c72f6e

restore inherit search_paths to Podfile

0ab0ea3

paulb777 force-pushed the pb-travis-cp15 branch from 31524d2 to 0ab0ea3 Compare May 13, 2018 14:43

Add -all_load to Firestore Example so all C++ is available for tests

57a1606

paulb777 force-pushed the pb-travis-cp15 branch from 9400f20 to 57a1606 Compare May 13, 2018 16:42

paulb777 changed the title ~~Update travis to use CocoaPods 1.5.2 (WIP)~~ Update travis to use CocoaPods 1.5.2 May 13, 2018

paulb777 requested a review from wilhuff May 13, 2018 17:16

wilhuff reviewed May 13, 2018

View reviewed changes

paulb777 commented May 13, 2018

View reviewed changes

wilhuff suggested changes May 13, 2018

View reviewed changes

commit pod integrated Xcode project

b4ade0a

wilhuff approved these changes May 14, 2018

View reviewed changes

paulb777 merged commit 97dc3a3 into master May 14, 2018

wilhuff deleted the pb-travis-cp15 branch May 14, 2018 15:21

firebase locked and limited conversation to collaborators Nov 4, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update travis to use CocoaPods 1.5.2 #1103

Update travis to use CocoaPods 1.5.2 #1103

paulb777 commented Apr 14, 2018 •

edited

Loading

paulb777 commented Apr 14, 2018

wilhuff commented Apr 17, 2018

paulb777 commented Apr 17, 2018

paulb777 commented May 12, 2018

paulb777 commented May 13, 2018

paulb777 commented May 13, 2018

wilhuff May 13, 2018

paulb777 May 13, 2018 •

edited

Loading

paulb777 May 13, 2018

wilhuff May 13, 2018

paulb777 May 14, 2018

wilhuff left a comment

wilhuff May 13, 2018

wilhuff left a comment

Update travis to use CocoaPods 1.5.2 #1103

Update travis to use CocoaPods 1.5.2 #1103

Conversation

paulb777 commented Apr 14, 2018 • edited Loading

paulb777 commented Apr 14, 2018

wilhuff commented Apr 17, 2018

paulb777 commented Apr 17, 2018

paulb777 commented May 12, 2018

paulb777 commented May 13, 2018

paulb777 commented May 13, 2018

wilhuff May 13, 2018

Choose a reason for hiding this comment

paulb777 May 13, 2018 • edited Loading

Choose a reason for hiding this comment

paulb777 May 13, 2018

Choose a reason for hiding this comment

wilhuff May 13, 2018

Choose a reason for hiding this comment

paulb777 May 14, 2018

Choose a reason for hiding this comment

wilhuff left a comment

Choose a reason for hiding this comment

wilhuff May 13, 2018

Choose a reason for hiding this comment

wilhuff left a comment

Choose a reason for hiding this comment

paulb777 commented Apr 14, 2018 •

edited

Loading

paulb777 May 13, 2018 •

edited

Loading