Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firestore: Update spec tests #10445

Merged
merged 2 commits into from
Nov 2, 2022
Merged

Firestore: Update spec tests #10445

merged 2 commits into from
Nov 2, 2022

Conversation

dconeybe
Copy link
Contributor

@dconeybe dconeybe commented Nov 2, 2022

Update the spec tests from https://github.com/firebase/firebase-js-sdk/tree/master/packages/firestore/test/unit/specs/ at commit firebase/firebase-js-sdk@9e9ee7b.

Note: The spec test changes from firebase/firebase-js-sdk#6624 were manually reverted in this PR because otherwise the tests will fail. This will be fixed, and the spec tests updated, by #10437.

#no-changelog

@dconeybe dconeybe self-assigned this Nov 2, 2022
@dconeybe dconeybe requested a review from milaGGL November 2, 2022 18:39
@google-oss-bot
Copy link

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestore.framework

    Overall coverage changed from 88.22% (db6af01) to 88.18% (55e2dda) by -0.04%.

    FilenameBase (db6af01)Merge (55e2dda)Diff
    exception.cc84.21%23.68%-60.53%
    exception_apple.mm65.52%96.55%+31.03%
    leveldb_key.cc98.14%98.82%+0.69%
    task.cc95.65%94.78%-0.87%
    write_stream.cc94.37%91.55%-2.82%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/SHrZaC4FYm.html

milaGGL
milaGGL approved these changes Nov 2, 2022
View reviewed changes
Copy link
Contributor

@milaGGL milaGGL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dconeybe dconeybe merged commit 9c6cbf7 into master Nov 2, 2022
@dconeybe dconeybe deleted the dconeybe/SpecTestUpdate branch November 2, 2022 19:19
@firebase firebase locked and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@milaGGL milaGGL milaGGL approved these changes

Assignees

@dconeybe dconeybe

Labels
api: firestore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dconeybe @google-oss-bot @milaGGL