Protobuf crash on 32-bit devices in PHTFlatFilePhenotype and Firestore (leveldb) #3851
Comments
This comment has been minimized.
This comment has been minimized.
|
Please share the Podfile and Podfile.lock. Also, any other patterns in where the crashes occur like iOS versions, etc. |
|
I am seeing the same crash on 2 apps. @paulb777 The crashes I am seeing appear to be from iOS 9 and iOS 10 only on both apps. @fangyuxi what version of Xcode did you compile the build with? (Just wondering if other users haven’t spotted this yet, or if it is an issue compiling against the Xcode 11 GM seed?) |
|
@neilmorton The Xcode version is 10.3. Not Xcode 11 GM. @paulb777 The specific compilation environment and podfile or podfile lock will be available to you tomorrow. |
|
@fangyuxi That’s interesting about the Xcode version. |
|
@neilmorton Yes iOS 9 and iOS 10 Only |
|
@neilmorton Now I am concerned about whether this Crash will cause iOS 9 and iOS 10 users to not use the App properly(I don't have an iPhone for iOS9 or iOS 10 to test.). If the user only occasionally encounters this Crash, then we still have time to fix it. |
|
@fangyuxi ok. I was limiting Firebase to 6.5.0 before my latest build due to a previous issue. I thought that was fixed, but seems there is now a new issue. |
|
@fangyuxi Looking at the data in Fabric I am sufficiently concerned by the number of iOS 9 / 10 users affected that I am reverting to the Firebase build that I had limited to due to the past issues. Podfile update: |
|
@neilmorton Please check to see if these versions are stable? Thank you very much ! Installing AFNetworking (3.2.1) |
|
@fangyuxi I have now locked Firebase back to 6.5.0 (reverted to what I was running previously): I have done this as there wasn't an issue previously and I want the iOS 9 and iOS 10 users back up and running. Looking at your information, it seems that you have Have you added the I hope this helps. |
|
@neilmorton OK Thank you. |
|
I believe that the backtrace shown would only come from |
|
It seems that this Crash only come from FirebasePerformance, but now I am ready to roll back the version to 6.7.0. Because there are too many users showing this Crash.I guess that after removing FirebasePerformance, the Crash should not appear, but updating the app version takes time, affects many users, so dare not try to remove FirebasePerformance. Thank you. Also, if this is configured(pod 'Firebase/Core', '~> 6.7.0'), will all the dependent Pods roll back to 6.7.0? Installing Fabric (1.10.2) Thank you again. |
You are welcome @fangyuxi |
@paulb777 Unfortunately I am in the same position as @fangyuxi. I had issues after moving up past 6.5.0 previously in that I was seeing a raft of I had just made the decision to lift that version hold with this latest release to now experience this new issue across 4 apps with the latest builds ready for iOS 13. I don't really want to risk just removing Rather I have, as mentioned above, locked them all back to 6.5.0. In the meantime I shall consider the options! |
@fangyuxi If you run |
|
If you run if you run
Thus if you do a @fangyuxi It looks like you still have 3.1.2. Please confirm the issue is still occurring with 3.1.4. |
|
Hi @paulb777 I have obtained the details of this app build binary. Hope to help. This is the details of the App that has Crash. The pod install info. |
|
Same issue here :'( iOS 10 only, Firebase dependencies:
|
|
@bill350 Is your lowest platform supported iOS 10? |
Yes, iOS 10 -> iOS 13 |
|
Thanks for the additional data about iOS versions. It seems that this is an issue for iOS 9 and iOS 10. Maybe also iOS 8? |
|
My lowest supported build is iOS 9, and iOS 9 and 10 are affected for me. As you say, it could be for 8 too, but I can’t say, sorry. |
|
Hello, My lowest platform support is iOS 10. |
|
Hello, It only started occurring for us when we released custom tracing for the first time on 14th September. It hasn't happened for any other versions, this would seem to indicate something wrong with custom performance tracing. The following are the Firebase versions we're using: We're going to remove custom tracing until we can figure out what this issue is. |
The code in question hasn't change in a long time so the cause of firebase/firebase-ios-sdk#3851 still appears to be an Xcode 11 clang change/bug; but this does appear to be slightly better code for the work being done.
|
We're continuing to investigate. The initial proposed Protobuf PR (see above) still causes an alignment exception. The best known workaround is still to use the Also, even though the initial bug report says Xcode 10 was used, we're only able to reproduce with Xcode 11 builds. Is anyone else seeing the issue from an Xcode 10 build? |
|
@paulb777 I saw one instance in an app which was dated around the 8th and was on an Xcode 10 build. But looking now I can't see it in Fabric. So, I think it may have been an anomaly. The rest of mine were with Xcode 11. |
|
@paulb777 I use xCode 10 right now. Can confirm crash & workaround. |
|
Yes, we are getting this issue with Xcode 10.2.1 also. |
|
We are getting same crash on iOS 11 and 12 with 64 Bit Devices. |
|
Our production build that crashes is built with Xcode 10.3. We don't have any builds in production with Xcode 11 yet. |
@Nishant-goibibo what specific device? I didn't think arm64 had unaligned memory issues. Or are you maybe build 32bit only and running that on arm64? |
…6672) The code in question hasn't change in a long time so the cause of firebase/firebase-ios-sdk#3851 still appears to be an Xcode 11 clang change/bug; but this does appear to be slightly better code for the work being done. Cleanup along the way for #6679
|
The protobuf fix is in progress at protocolbuffers/protobuf#6678 |
…rotocolbuffers#6672) The code in question hasn't change in a long time so the cause of firebase/firebase-ios-sdk#3851 still appears to be an Xcode 11 clang change/bug; but this does appear to be slightly better code for the work being done. Cleanup along the way for protocolbuffers#6679
…rotocolbuffers#6672) The code in question hasn't change in a long time so the cause of firebase/firebase-ios-sdk#3851 still appears to be an Xcode 11 clang change/bug; but this does appear to be slightly better code for the work being done. Cleanup along the way for protocolbuffers#6679
|
hey everyone! when will be update? |
|
Protobuf 3.9.2 has now been published to CocoaPods with the fix.
|
|
Thanks to everyone who contributed to this thread with backtraces and detailed crash information that helped us track this one down! |
|
@paulb777 any timeline for a carthage update including the fix? |
|
@datalogen Are you seeing the crash with a Carthage distribution? |
|
@paulb777 Yes, we are seeing a similar crash with a Carthage distribution. We have quite a few customers running on older devices - iOS 9 and 10. Crashed: com.google.firebase.firestore |
|
@paulb777 Debug builds are not showing the issue - release builds however are consistently crashing on my 32-bit device running iOS 9.3.5. |
|
Thanks @datalogen. The fix will be included in the Firebase 6.9.0 Carthage (and zip) release that is planned to go out early in the week. |
|
Hello, |
I'm using firebase 6.8.1
When new App is released at Appstore, I found more crashs appear in firebase dashboard. I do not use ProtoBuf directly
I updated all Pods, before upload package to Appstore. All componets are newest.
This is the details of the App that has Crash.
The pod install info.
The text was updated successfully, but these errors were encountered: