Renamed FUNSerializer to FunctionsSerializer (#13410)

firebase · Jul 27, 2024 · 26dab27 · 26dab27
1 parent af5efdb
commit 26dab27
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 11 deletions.
diff --git a/FirebaseFunctions/Sources/Functions.swift b/FirebaseFunctions/Sources/Functions.swift
@@ -47,7 +47,7 @@ enum FunctionsConstants {
   /// The projectID to use for all function references.
   private let projectID: String
   /// A serializer to encode/decode data and return values.
-  private let serializer = FUNSerializer()
+  private let serializer = FunctionsSerializer()
   /// A factory for getting the metadata to include with function calls.
   private let contextProvider: FunctionsContextProvider
 

diff --git a/FirebaseFunctions/Sources/FunctionsError.swift b/FirebaseFunctions/Sources/FunctionsError.swift
@@ -211,7 +211,7 @@ extension FunctionsErrorCode {
 
 func FunctionsErrorForResponse(status: NSInteger,
                                body: Data?,
-                               serializer: FUNSerializer) -> NSError? {
+                               serializer: FunctionsSerializer) -> NSError? {
   // Start with reasonable defaults from the status code.
   var code = FunctionsCodeForHTTPStatus(status)
   var description = code.descriptionForErrorCode

diff --git a/FirebaseFunctions/Sources/Internal/FunctionsSerializer.swift b/FirebaseFunctions/Sources/Internal/FunctionsSerializer.swift
@@ -20,15 +20,15 @@ private enum Constants {
   static let dateType = "type.googleapis.com/google.protobuf.Timestamp"
 }
 
-extension FUNSerializer {
+extension FunctionsSerializer {
   enum Error: Swift.Error {
     case unsupportedType(typeName: String)
     case unknownNumberType(charValue: String, number: NSNumber)
     case invalidValueForType(value: String, requestedType: String)
   }
 }
 
-class FUNSerializer: NSObject {
+class FunctionsSerializer: NSObject {
   private let dateFormatter: DateFormatter = {
     let formatter = DateFormatter()
     formatter.dateFormat = "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'"

diff --git a/...unctions/Tests/Unit/SerializerTests.swift → ...Tests/Unit/FunctionsSerializerTests.swift b/...unctions/Tests/Unit/SerializerTests.swift → ...Tests/Unit/FunctionsSerializerTests.swift
@@ -24,12 +24,12 @@ import FirebaseCore
 
 import XCTest
 
-class SerializerTests: XCTestCase {
-  private var serializer: FUNSerializer!
+class FunctionsSerializerTests: XCTestCase {
+  private var serializer: FunctionsSerializer!
 
   override func setUp() {
     super.setUp()
-    serializer = FUNSerializer()
+    serializer = FunctionsSerializer()
   }
 
   func testEncodeNull() throws {
@@ -98,7 +98,7 @@ class SerializerTests: XCTestCase {
     let dictLowLong = ["@type": typeString, "value": badVal]
     do {
       _ = try serializer.decode(dictLowLong) as? NSNumber
-    } catch let FUNSerializer.Error.invalidValueForType(value, type) {
+    } catch let FunctionsSerializer.Error.invalidValueForType(value, type) {
       XCTAssertEqual(value, badVal)
       XCTAssertEqual(type, typeString)
       return
@@ -136,7 +136,7 @@ class SerializerTests: XCTestCase {
     let coded = ["@type": typeString, "value": tooHighVal]
     do {
       _ = try serializer.decode(coded) as? NSNumber
-    } catch let FUNSerializer.Error.invalidValueForType(value, type) {
+    } catch let FunctionsSerializer.Error.invalidValueForType(value, type) {
       XCTAssertEqual(value, tooHighVal)
       XCTAssertEqual(type, typeString)
       return
@@ -241,7 +241,7 @@ class SerializerTests: XCTestCase {
       let _ = try serializer.encode(input)
       XCTFail("Expected an error")
     } catch {
-      guard case let .unsupportedType(typeName: typeName) = error as? FUNSerializer.Error
+      guard case let .unsupportedType(typeName: typeName) = error as? FunctionsSerializer.Error
       else {
         return XCTFail("Unexpected error: \(error)")
       }
@@ -257,7 +257,7 @@ class SerializerTests: XCTestCase {
       let _ = try serializer.decode(input)
       XCTFail("Expected an error")
     } catch {
-      guard case let .unsupportedType(typeName: typeName) = error as? FUNSerializer.Error
+      guard case let .unsupportedType(typeName: typeName) = error as? FunctionsSerializer.Error
       else {
         return XCTFail("Unexpected error: \(error)")
       }