adds retry option to event triggered functions #370
Conversation
| @@ -168,6 +168,7 @@ export interface TriggerAnnotated { | |||
| httpsTrigger?: {}; | |||
| eventTrigger?: { | |||
| eventType: string; | |||
| failurePolicy?: object; | |||
There was a problem hiding this comment.
Curious as to why failurePolicy is inside the eventTrigger and not outside like the other options like timeout and memory? was that because it does not apply to http functions?
There was a problem hiding this comment.
This is per the Google cloud docs - since it only applies to event-triggered functions, its a property of EventTrigger: https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions#EventTrigger
| @@ -303,7 +304,9 @@ export function makeCloudFunction<EventData>({ | |||
| service, | |||
| }, | |||
| }); | |||
|
|
|||
| if (opts.retry) { | |||
| trigger.eventTrigger.failurePolicy = { retry: {} }; | |||
There was a problem hiding this comment.
Should this propagate the retry boolean instead of creating an empty object?
There was a problem hiding this comment.
Nope - strangely enough, google cloud expects an empty object of type Retry here: https://cloud.google.com/functions/docs/reference/rest/v1/projects.locations.functions#EventTrigger
|
Hmm, just saw this old issue that was closed, with reasoning for NOT implementing this: #297 - thoughts? |
|
To your comment about propagating - I believe the CLI already picks up the eventTrigger and sends the whole thing, so it shouldn't need any changes |
|
Makes sense, thanks for explaining! Regarding whether we should implement this, I think @laurenzlong would have the context here. Lauren - have we set on the decision to not implement retries or have things changed since that time? |
|
Chatted with Lauren offline - because this option will retry your function for 7 days, it's rather dangerous to expose as a native functionality in firebase-functions, as even the slightest error in your functions code can seriously rack up your bill. We will still continue exposing the ability to add a retry through the GCP console after a function has been deployed. |
|
Closing since Firebase has chosen not to expose this potentially dangerous functionality - users who need this option can access it through GCF |
|
Is there any way it could be still exposed, but would require an explicit acknowledgement of a risk, either as a confirmation question in interactive shells or a flag for CI/CD systems? |
|
@merlinnot : @laurenzlong - did this option come up in the discussion? Thoughts? |
Description
Adds retry option for event triggered functions, to match gcloud functions. https://cloud.google.com/functions/docs/reference/rpc/google.cloud.functions.v1#google.cloud.functions.v1.EventTrigger
Code sample
//adds an onCreate function for auth, with retry enabled
functions.runWith({retry:true})
.auth.user()
.onCreate(user => user);