New structured logger not applying labels

[rhodgkins]

This is using the new require('firebase-functions').logger in Node 10.

According to the container logs contract we should be able to write labels for a LogEntry by using the special field logging.googleapis.com/labels. However these labels just get applied to the jsonPayload in the Logs Viewer (in GCP).

I've also tried just a plan labels field with no success.

Reproduction

Deploy a function that contains the following and run the function:

const { logger } = require('firebase-functions')

logger.write({
    severity: 'INFO',
    message: 'Should include labels (via labels)',
    labels: {
      label1: 'some value'
    }
})


logger.write({
    severity: 'INFO',
    message: 'Should include labels (via logging.googleapis.com/labels)',
    'logging.googleapis.com/labels': {
      label1: 'some value'
    }
})

Logs Viewer output:

I'd expect the jsonPayload[labels] and jsonPayload[logging.googleapis.com/labels] to be included under the labels at the root.

It might be the case its not supported but wanted to check as other special fields from the list (i.e. message, timestamp) are being converted correctly!

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[mbleigh]

This is a backend issue (internal id: b/146219077) that is currently being looked at. There's nothing specific that we can do in this repo to address it, but I'll leave this open and hopefully remember to come back and ping it when the backend is fixed.

Thanks for the report!

[rhodgkins]

Thanks!

Should we be using labels or logging.googleapis.com/labels so it’ll just work once the bug is fixed?

[mbleigh]

Use logging.googleapis.com/labels

…

On Wed, Jun 10, 2020, 10:00 AM Rich Hodgkins ***@***.***> wrote: Thanks! Should we be using labels or logging.googleapis.com/labels so it’ll just work once the bug is fixed? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#703 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAAAH7T3553KCRFNA5QJXD3RV633FANCNFSM4N2I3IEA> .

[rhodgkins]

@mbleigh its been a few months so I thought I'd check in and see if its been fixed? Thanks in advance

[rhodgkins]

@mbleigh went to check on this and with the original above code logging.googleapis.com/labels are now completely dropped...

[voxmaster]

Same issue with

• Cloud Run
• Cloud Functions

Cross all languages and any Structured Logs

[rhodgkins]

Same issue with

• Cloud Run
• Cloud Functions

Cross all languages and any Structured Logs

I haven't tried Cloud Functions (but Firebase functions are built on top of these so I imagine its the same as this issue), but labels are showing for me with Cloud Run when using the logging.googleapis.com/labels key.

[taeold]

2021 update: Cloud Functions backend is working on a fix to this issue. I will come back in another week to provide an update.

[taeold]

I'm reading from internal tracking bug that the fix should land in a week or so. Will provide another update in a few weeks.

[taeold]

Personally I'm seeing the log labels being correctly applied in Cloud Monitoring. The rollout is only ~90% done, but you may also start to see the label being applied correctly. Rollout should be fully completed in the next couple of days.

[rhodgkins]

Yep all working for me now too thanks @taeold