Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-hide EmulatorSettings API #1712

Merged
merged 5 commits into from
Jun 24, 2020
Merged

Un-hide EmulatorSettings API #1712

merged 5 commits into from
Jun 24, 2020

Conversation

samtstern
Copy link
Contributor

@samtstern samtstern commented Jun 24, 2020

Follow up to #1672 #1688 #1690

Questions:

  • Where is the CHANGELOG for firebase-common and firebase-functions?
  • Should I also bump the -ktx library versions?

@samtstern
Copy link
Contributor Author

Assigning to @ashwinraghav for review since Vlad is out.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 24, 2020

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (0eaca5e) Head (fce4ebe5) Diff
    aar 38.1 kB 38.1 kB +47 B (+0.1%)
    apk (aggressive) 82.7 kB 82.7 kB -10 B (-0.0%)
    apk (debug) 772 kB 772 kB -14 B (-0.0%)
    apk (release) 637 kB 637 kB -5 B (-0.0%)
  • firebase-components

    Type Base (0eaca5e) Head (fce4ebe5) Diff
    apk (debug) 35.8 kB 35.8 kB +1 B (+0.0%)
  • firebase-database

    Type Base (0eaca5e) Head (fce4ebe5) Diff
    aar 482 kB 482 kB -7 B (-0.0%)
    apk (aggressive) 326 kB 326 kB +18 B (+0.0%)
    apk (debug) 1.29 MB 1.29 MB +198 B (+0.0%)
    apk (release) 1.09 MB 1.09 MB -14 B (-0.0%)
  • firebase-database-collection

    Type Base (0eaca5e) Head (fce4ebe5) Diff
    apk (aggressive) 314 kB 314 kB -7 B (-0.0%)
    apk (debug) 1.07 MB 1.07 MB +7 B (+0.0%)
  • firebase-firestore

    Type Base (0eaca5e) Head (fce4ebe5) Diff
    aar 996 kB 996 kB +3 B (+0.0%)
    apk (aggressive) 461 kB 461 kB -2 B (-0.0%)
    apk (debug) 3.79 MB 3.79 MB +95 B (+0.0%)
    apk (release) 3.16 MB 3.16 MB +11 B (+0.0%)
  • firebase-functions

    Type Base (0eaca5e) Head (fce4ebe5) Diff
    aar 26.4 kB 26.4 kB +30 B (+0.1%)
    apk (debug) 1.37 MB 1.37 MB +82 B (+0.0%)
    apk (release) 1.17 MB 1.17 MB +64 B (+0.0%)
  • protolite-well-known-types

    Type Base (0eaca5e) Head (fce4ebe5) Diff
    apk (aggressive) 140 kB 140 kB +7 B (+0.0%)
    apk (debug) 768 kB 768 kB +1 B (+0.0%)

Test Logs

Notes

Head commit (fce4ebe5) is created by Prow via merging commits: 0eaca5e f029163.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 24, 2020

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.01% (0eaca5e) to 49.99% (fce4ebe5) by -0.02%.

    Filename Base (0eaca5e) Head (fce4ebe5) Diff
    DoubleNode.java 100.00% 88.89% -11.11%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (fce4ebe5) is created by Prow via merging commits: 0eaca5e f029163.

@rlazo
Copy link
Collaborator

rlazo commented Jun 24, 2020

About bumping -ktx, please do. Thanks!

@samtstern
Copy link
Contributor Author

@rlazo where do I do that? I don't see a gradle.properties for the KTX SDKs that contains a version number. Do they even have their own versions or do they automatically inherit?

@rlazo
Copy link
Collaborator

rlazo commented Jun 24, 2020

argh... my bad. Yes, they inherit the version from the parent's version var. No work needed!

@samtstern samtstern requested a review from rlazo June 24, 2020 16:23
@rlazo
Copy link
Collaborator

rlazo commented Jun 24, 2020

Changelogs for firebase-common and firebase-functions are generated during the release process, you'll not be able to find them here.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jun 24, 2020

@samtstern: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
smoke-tests f029163 link /test smoke-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@samtstern
Copy link
Contributor Author

/test device-check-changed

@samtstern samtstern merged commit 4748715 into master Jun 24, 2020
samtstern added a commit that referenced this pull request Jun 29, 2020
samtstern added a commit that referenced this pull request Jun 30, 2020
@firebase firebase locked and limited conversation to collaborators Jul 25, 2020
@kaibolay kaibolay deleted the ss-unhide-emulator-settings branch September 14, 2022 17:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes Override cla size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants