Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make removeSnapshotsInSyncListener run on AQ #1572

Merged
merged 1 commit into from
May 19, 2020
Merged

Make removeSnapshotsInSyncListener run on AQ #1572

merged 1 commit into from
May 19, 2020

Conversation

thebrianchen
Copy link

Porting from iOS.

@thebrianchen thebrianchen self-assigned this May 19, 2020
@googlebot googlebot added the cla: yes Override cla label May 19, 2020
@google-oss-bot
Copy link
Contributor

Binary Size Report

Affected SDKs

  • firebase-common

    Type Base (56fc810) Head (e8e37a5e) Diff
    apk (aggressive) 82.5 kB 82.5 kB -14 B (-0.0%)
    apk (debug) 770 kB 770 kB +2 B (+0.0%)

  • firebase-components

    Type Base (56fc810) Head (e8e37a5e) Diff
    apk (aggressive) 10.9 kB 11.0 kB +11 B (+0.1%)
    apk (debug) 35.8 kB 35.9 kB +29 B (+0.1%)

  • firebase-database-collection

    Type Base (56fc810) Head (e8e37a5e) Diff
    apk (aggressive) 314 kB 314 kB -6 B (-0.0%)
    apk (debug) 1.07 MB 1.07 MB -13 B (-0.0%)

  • firebase-firestore

    Type Base (56fc810) Head (e8e37a5e) Diff
    aar 1.07 MB 1.07 MB +465 B (+0.0%)
    apk (aggressive) 443 kB 443 kB -5 B (-0.0%)
    apk (debug) 3.74 MB 3.74 MB -69 B (-0.0%)
    apk (release) 3.13 MB 3.13 MB +51 B (+0.0%)

  • protolite-well-known-types

    Type Base (56fc810) Head (e8e37a5e) Diff
    apk (aggressive) 122 kB 122 kB -4 B (-0.0%)
    apk (debug) 643 kB 643 kB -5 B (-0.0%)

Test Logs

Notes

Head commit (e8e37a5e) is created by Prow via merging commits: 56fc810 9aef4e4.

@google-oss-bot
Copy link
Contributor

Coverage Report

Affected SDKs

No changes between base commit (56fc810) and head commit (e8e37a5e).

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (e8e37a5e) is created by Prow via merging commits: 56fc810 9aef4e4.

@thebrianchen thebrianchen requested a review from wilhuff May 19, 2020 20:24
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen May 19, 2020
wilhuff
wilhuff approved these changes May 19, 2020
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff May 19, 2020
@thebrianchen thebrianchen merged commit b1172c9 into master May 19, 2020
@thebrianchen thebrianchen deleted the bc/enqueue-listen branch May 19, 2020 22:50
@firebase firebase locked and limited conversation to collaborators Jun 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@wilhuff wilhuff wilhuff approved these changes

Assignees

@thebrianchen thebrianchen

Labels
api: firestore cla: yes Override cla size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thebrianchen @google-oss-bot @wilhuff @googlebot