make SafetySettings#method nullable (#6379)

Co-authored-by: David Motsonashvili <[email protected]> Co-authored-by: Rodrigo Lazo <[email protected]>
firebase · Oct 17, 2024 · dd23959 · dd23959
1 parent 2dd9beb
commit dd23959
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/firebase-vertexai/CHANGELOG.md b/firebase-vertexai/CHANGELOG.md
@@ -18,6 +18,7 @@
 * [changed] **Breaking Change**: Replaced sealed classes with abstract classes for `StringFormat`. (#6334)
 * [changed] **Breaking Change**: Refactored enum classes to be normal classes. (#6340)
 * [changed] **Breaking Change**: Marked `GenerativeModel` properties as private. (#6309)
+* [changed] **Breaking Change**: Changed `method` parameter type to be nullable in `SafetySettings`. (#6379)
 
 
 # 16.0.0-beta05

diff --git a/firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/internal/util/conversions.kt b/firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/internal/util/conversions.kt
@@ -100,7 +100,7 @@ internal fun SafetySetting.toInternal() =
   com.google.firebase.vertexai.common.shared.SafetySetting(
     harmCategory.toInternal(),
     threshold.toInternal(),
-    method.toInternal()
+    method?.toInternal()
   )
 
 internal fun makeMissingCaseException(source: String, ordinal: Int): SerializationException {

diff --git a/firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/SafetySetting.kt b/firebase-vertexai/src/main/kotlin/com/google/firebase/vertexai/type/SafetySetting.kt
@@ -22,10 +22,11 @@ package com.google.firebase.vertexai.type
  *
  * @param harmCategory The relevant [HarmCategory].
  * @param threshold The threshold form harm allowable.
- * @param method Specify if the threshold is used for probability or severity score.
+ * @param method Specify if the threshold is used for probability or severity score, if not
+ * specified it will default to [HarmBlockMethod.PROBABILITY].
  */
 public class SafetySetting(
   internal val harmCategory: HarmCategory,
   internal val threshold: HarmBlockThreshold,
-  internal val method: HarmBlockMethod = HarmBlockMethod.PROBABILITY
+  internal val method: HarmBlockMethod? = null,
 )