Implementing the sendMulticast() API for FCM #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chong-shao
approved these changes
Mar 11, 2019
Feiyang1
approved these changes
Mar 12, 2019
hiranya911
added a commit
that referenced
this pull request
Mar 14, 2019
* Initial implementation for batch send * Unit tests for BatchRequestClient * Finished sendAll() implementation * Fixed some lint errors * Fixed messaging test imports * Adding more tests * Increased test coverage * Updated tests * Implemented multipart parsing with dicer for performance * Increased test coverage for HttpClient * Added a test case for zlib * Removed http-message-parser frm required dependencies * Added some documentation * Updated comments * Trigger CI * Fixed some typos; Reduced batch size limit to 100 * More documentation and clean up * Updated docs; Other code review feedback * Handling malformed responses in parseHttpResponse() * Implementing the sendMulticast() API for FCM (#473) * Implementing sendMulticast() API * Added integration test * Fixed a comment * Readability improvement in the copy operation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #453. The
sendMulticast()API uses thesendAll()method to send a single message to a batch of 100 tokens.