Refactoring unit tests to reduce dependency on credentials #431
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to implement some changes to our credentials, but every time I touch that code a large number of unit tests break. This is because many of our unit tests are tightly coupled with the credentials. A lot of the tests emulate the behavior of credentials by mocking the HTTP call to token servers, and if the credentials change how they talk to the servers even slightly, all the dependent tests break.
This PR reduces this level of coupling by implementing the following changes:
FirebaseApp.Internals.getToken()
method.FirebaseApp
andFirebaseNamespace
unit tests stub thegetAccessToken()
method on the credential classes.Credential
unit tests are allowed to mock the token server HTTP calls. To this end theutils.mockFetchAccessTokenRequests()
method has been removed.