Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert regression introduced in #1257 #1277

Merged
merged 1 commit into from
May 18, 2021
Merged

fix: Revert regression introduced in #1257 #1277

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/unit/storage/storage.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,7 @@ describe('Storage', () => {
});
});

describe.only('Emulator mode', () => {
describe('Emulator mode', () => {
const VALID_EMULATOR_HOST = 'localhost:9199';
const INVALID_EMULATOR_HOST = 'https://localhost:9199';

Expand All @@ -136,7 +136,7 @@ describe('Storage', () => {
expect(() => new Storage(mockApp)).to.throw(
'FIREBASE_STORAGE_EMULATOR_HOST should not contain a protocol');
});

after(() => {
delete process.env.STORAGE_EMULATOR_HOST;
delete process.env.FIREBASE_STORAGE_EMULATOR_HOST;
Expand Down