feat(auth): Added code flow support for OIDC flow. #1220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
suggested changes
Apr 14, 2021
hiranya911
suggested changes
Apr 15, 2021
lsirac
reviewed
Apr 16, 2021
lsirac
reviewed
Apr 16, 2021
lsirac
approved these changes
Apr 20, 2021
bojeil-google
suggested changes
Apr 20, 2021
bojeil-google
suggested changes
Apr 23, 2021
| @@ -3503,12 +3503,20 @@ AUTH_REQUEST_HANDLER_TESTS.forEach((handler) => { | |||
| enabled: true, | |||
| clientId: 'CLIENT_ID', | |||
| issuer: 'https://oidc.com/issuer', | |||
| clientSecret: 'CLIENT_SECRET', | |||
There was a problem hiding this comment.
I am concerned about legacy customers and would recommend keeping a test without clientSecret and responseType. Can you add new tests instead of modifying the existing ones?
There was a problem hiding this comment.
I add tests for createOAuthIdpConfig and updateOAuthIdpConfig
bojeil-google
approved these changes
Apr 23, 2021
egilmorez
approved these changes
May 11, 2021
| /** | ||
| * The interface representing OIDC provider's response object for OAuth | ||
| * authorization flow. | ||
| * We need either of them to be true, there are two cases: |
There was a problem hiding this comment.
This comment could be improved. Suggest:
" * One of the following must be true:
- If
codeis set to true, then we are doing code flow. - If
dTokenis set to true, then we are doing ID token flow."
(Assuming that backticks are rendered as code font, and that "ID token flow" is a thing, separate from the literal idToken flag.
This was referenced Jun 20, 2024
This was referenced Jul 17, 2024
This was referenced Jul 27, 2024
This was referenced Aug 10, 2024
This was referenced Aug 17, 2024
This was referenced Aug 28, 2024
This was referenced Sep 5, 2024
This was referenced Sep 24, 2024
This was referenced Oct 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTE: Added code flow support for OIDC flow(previously only support idToken flow).
RELEASE NOTE: Defined
OAuthResponseTypefor specifying responseType either idToken or code.RELEASE NOTE: Defined two new error codes:
INVALID_OAUTH_RESPONSETYPEandMISSING_OAUTH_CLIENT_SECRET.