Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emulator-based integration tests. #1155

Merged
merged 9 commits into from
Mar 23, 2021
Merged

Conversation

yuchenshi
Copy link
Member

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

This is a follow up to #1148 and enables emulator-based integration tests.

Testing

This covers Firestore and most of Auth and database.

API Changes

N/A

@yuchenshi yuchenshi force-pushed the ys/integration-emulator branch from c653f95 to 9aecf74 Compare February 4, 2021 19:06
@yuchenshi yuchenshi marked this pull request as ready for review February 5, 2021 21:23
@yuchenshi yuchenshi requested a review from hiranya911 February 5, 2021 21:23
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuchenshi. Really like how this is turning out. My main point of feedback is about managing the emulator-based integration tests entirely within the Actions workflow, rather than in package.json. That's consistent with how we did this in Python, and keeps the package.json file clean of changes.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@hiranya911 hiranya911 assigned yuchenshi and unassigned hiranya911 Feb 5, 2021
@yuchenshi yuchenshi requested a review from hiranya911 February 10, 2021 17:23
@yuchenshi yuchenshi assigned hiranya911 and unassigned yuchenshi Feb 10, 2021
@yuchenshi
Copy link
Member Author

Sorry I was OOO and I've now reverted package.json changes as requested.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuchenshi. LGTM with a couple of nits. Feel free to merge once the comments are addressed.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@hiranya911 hiranya911 assigned yuchenshi and unassigned hiranya911 Feb 11, 2021
@yuchenshi
Copy link
Member Author

yuchenshi commented Feb 11, 2021

I see one flaky test here and I'll investigate later. Don't merge for now please! https://github.com/firebase/firebase-admin-node/pull/1155/checks?check_run_id=1881208101#step:7:197

It's unclear if it's flaky due to some issue in Auth Emulator or maybe the test itself has race conditions that got worse since Auth Emulator is much faster than prod.

@yuchenshi yuchenshi merged commit 97d3823 into master Mar 23, 2021
@yuchenshi yuchenshi deleted the ys/integration-emulator branch March 23, 2021 00:48
@yuchenshi
Copy link
Member Author

Merging now since the tests now pass. Feel free to skip that one test for emulators if this comes up again. Let's at least have coverage for the other tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants