feat(auth): Add Argon2 Hashing Algorithm support #637
Conversation
|
Looks good to me. |
| } | ||
| } | ||
|
|
||
| public enum Argon2HashType { |
There was a problem hiding this comment.
I wonder if this could use another layer of abstraction. Similar to what we have done with Hmac and RepeatableHash. We could introduce an abstract class for ARGON2Hash and implementations for ARGON2d, ARGON2i, and ARGON2id. WDYT?
There was a problem hiding this comment.
I think that's unnecessary here. For HMAC, it makes sense to add a layer of abstraction since the algorithms are identified as different from one another (HMAC_SHA256 HMAC_SHA1 HMAC_MD5, etc). Here ARGON2 is the algorithm, the hash-types are an additional configuration for the same algorithm.
There was a problem hiding this comment.
I see. That makes sense. Thanks, Sam!
src/test/java/com/google/firebase/auth/hash/InvalidHashTest.java
Outdated
Show resolved
Hide resolved
| VERSION_10, | ||
| VERSION_13 |
There was a problem hiding this comment.
They are the supported versions, as per the API: https://cloud.google.com/identity-platform/docs/reference/rest/v1/Argon2Parameters#version
…Parameters` field
lahirumaramba
changed the title
Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:
Discussion
Testing
API Changes
RELEASE NOTE: Added
Argon2hashing algorithm support in theimportUsers()API.